Closed Bug 900192 Opened 6 years ago Closed 6 years ago

ValueError when exception is raised in Talos (ValueError: incomplete format)

Categories

(Testing :: Talos, defect)

Product:
Testing
Component:
Talos
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set

Tracking

(firefox24 unaffected, firefox25 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla25
Tracking Flags:
Tracking Status
firefox24 --- unaffected
firefox25 --- fixed

People

(Reporter: jyeo, Assigned: jyeo)

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

[checked-in] Fix value error
1.26 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
[checked-in] Update talos version
649 bytes, patch
armenzg
: review+
Details | Diff | Splinter Review
Attachment #783979 - Flags: review?(jhammel)
(continuing from comment 1. My bad, I pressed enter too early)
https://bug895451.bugzilla.mozilla.org/attachment.cgi?id=783825 shows Talos detecting another firefox process and raising an exception but instead of having that exception raised, a ValueError is raised. It's because we are missing a "%s" at http://hg.mozilla.org/build/talos/file/0c96f76c9a26/talos/run_tests.py#l291.
Comment on attachment 783979 [details] [diff] [review]
[checked-in] Fix value error

r+; thanks for the fix!  feel free to land
Attachment #783979 - Flags: review?(jhammel) → review+
Landed: https://hg.mozilla.org/build/talos/rev/09e235f45c9b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Tweaking summary to allow for starring on TBPL.
Keywords: intermittent-failure
Summary: ValueError when exception is raised in Talos → ValueError when exception is raised in Talos (ValueError: incomplete format)
If I understand correctly, this is not yet fixed.

A patch needs to be provided to start using the latest talos revision:
http://hg.mozilla.org/integration/mozilla-inbound/file/default/testing/talos/talos.json#l8

Currently we're using the previous changeset.

It can be pushed to the try server to test it first by selecting the correct try syntax: http://trychooser.pub.build.mozilla.org/

Do we need to test it on try first? It looks pretty safe.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Armen Zambrano G. [:armenzg] (Release Enginerring) (EDT/UTC-4) from comment #10)
> Do we need to test it on try first?

I don't think so. And it's hard to reproduce the exception on try. It's easier to reproduce on your own local copy. You just need to have firefox opened while running talos to see the exception. ;)
Attachment #784547 - Flags: review?(armenzg)
https://hg.mozilla.org/mozilla-central/rev/2f0e77a1a12b
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Attachment #784547 - Attachment description: Update talos version → [checked-in] Update talos version
Attachment #784547 - Flags: review?(armenzg) → review+
Attachment #783979 - Attachment description: Fix value error → [checked-in] Fix value error
You need to log in before you can comment on or make changes to this bug.