900250 - Remove geo.gps.supl_server

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Doug Turner (:dougt)]

Currently supl is configure completely in the modem.  Along with the server fqdm, TLS enabled and the server's certificate also have to be enabled.  It is very easy to misconfigure the SUPL system.  I worry that the preference in gaia makes things more confusing.  In the best case, it is an override.

I tend to think we should remove:

   http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/GonkGPSGeolocationProvider.cpp#580

and put all of our trust in that the modem being configured properly.


Furthermore, the supl server we are asking OEMs/operators to use will be TLS enabled.  As i mentioned, part of the configuration is that you install the server's cert on the modem.  Because of this, if you ever change the preference in gaia... the supl connection will fail because of a mismatched cert (we're not updating the cert w/ this pref!).

Kan-ru, what do you think?

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Doug Turner (:dougt) from comment #0)
> Currently supl is configure completely in the modem.  Along with the server
> fqdm, TLS enabled and the server's certificate also have to be enabled.  It
> is very easy to misconfigure the SUPL system.  I worry that the preference
> in gaia makes things more confusing.  In the best case, it is an override.
> 
> I tend to think we should remove:
> 
>   
> http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/
> GonkGPSGeolocationProvider.cpp#580
> 
> and put all of our trust in that the modem being configured properly.
> 
> 
> Furthermore, the supl server we are asking OEMs/operators to use will be TLS
> enabled.  As i mentioned, part of the configuration is that you install the
> server's cert on the modem.  Because of this, if you ever change the
> preference in gaia... the supl connection will fail because of a mismatched
> cert (we're not updating the cert w/ this pref!).
> 
> Kan-ru, what do you think?

The GPS API requires a server name to connect to so we must have something to fill in. It was easier to test to read that from geo.gps.supl_server.

How about make it a ro.gps.supl_server property in the android property system so that it's read-only (at runtime) and could be configured for each device under the gonk build system.

Comment 2

[Doug Turner (:dougt)]

> The GPS API requires a server name to connect to so we must have something to fill in. It was easier to test to read that from geo.gps.supl_server.

My understanding is that we don't need to mess with this at all.  agps is configured by the OEM (just like the display driver, or file system).  for us, we can see what was set by looking at /etc/gps.conf.

Why do we have to make any call to the gps subsystem?

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Doug Turner (:dougt) from comment #2)
> > The GPS API requires a server name to connect to so we must have something to fill in. It was easier to test to read that from geo.gps.supl_server.
> 
> My understanding is that we don't need to mess with this at all.  agps is
> configured by the OEM (just like the display driver, or file system).  for
> us, we can see what was set by looking at /etc/gps.conf.

You mean parse /etc/gps.conf?
 
> Why do we have to make any call to the gps subsystem?

Because this line is required:
https://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/GonkGPSGeolocationProvider.cpp#583

Comment 4

[Doug Turner (:dougt)]

> mAGpsInterface->set_server(AGPS_TYPE_SUPL, suplServer.get(), suplPort);

That is really required?  That is really sad.  In this case, we should read /etc/gps.conf.

I'll ask some friends working on this to see if there is a reason for this.

Comment 5

[Doug Turner (:dougt)]

s/read/parse

Comment 6

[Doug Turner (:dougt)]

Until there is cert injection and TLS configuration APIs,  We should just read from the conf file:

https://www.codeaurora.org/cgit/quic/la/platform/frameworks/base/tree/services/java/com/android/server/location/GpsLocationProvider.java?h=jb_mr2#n195

https://www.codeaurora.org/cgit/quic/la/platform/frameworks/base/tree/services/java/com/android/server/location/GpsLocationProvider.java?h=jb_mr2#n468

Comment 7

[Chris Peterson [:cpeterson]]

The geo.gps.supl_server pref no longer exists.