mozharness should pass test-plugin-path to runxpcshelltests.py

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mihneadb, Assigned: mihneadb)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

This is necessary so we can get rid of the hardcoded defaulting that xpcshell.cpp does.
(Assignee)

Updated

6 years ago
Blocks: 899857
Created attachment 784096 [details] [diff] [review]
mozharness should pass test-plugin-path to runxpcshelltests.py
(Assignee)

Updated

6 years ago
Assignee: nobody → mihneadb
Ash run with the changes in this bug and in bug 899857 applied:
https://tbpl.mozilla.org/?tree=Ash&rev=46ca10eb1fb3
mozharness-ash seems to be busted (cannot install mozrunner)
(Assignee)

Updated

6 years ago
Attachment #784096 - Flags: review?(rail)

Updated

6 years ago
Attachment #784096 - Flags: review?(rail) → review+
Rail, do I need to do something else to get this landed/deployed?

Thanks
Flags: needinfo?(rail)

Comment 5

6 years ago
(In reply to Mihnea Dobrescu-Balaur (:mihneadb) from comment #4)
> Rail, do I need to do something else to get this landed/deployed?
> 
> Thanks

Once buildduty merges default to production (today, afaik) the patch will be live.
Flags: needinfo?(rail)

Comment 6

6 years ago
In other words, no further action required here.
(In reply to Rail Aliiev [:rail] from comment #6)
> In other words, no further action required here.

Great, thanks, I thought I needed to add a keyword or something.

Comment 8

5 years ago
Comment on attachment 784096 [details] [diff] [review]
mozharness should pass test-plugin-path to runxpcshelltests.py

pushed to https://hg.mozilla.org/build/mozharness/rev/dab6d1772285
and merged to production https://hg.mozilla.org/build/mozharness/rev/8c511238602b

Comment 9

5 years ago
Backed out

https://hg.mozilla.org/build/mozharness/rev/1ce7afcbbf12
https://hg.mozilla.org/build/mozharness/rev/c57bdead999d

b2g_emulator_vm mozilla-inbound opt test xpcshell on 2013-08-02 11:13:08 PDT for push 834374d5596f

11:14:22    FATAL - Uncaught exception: Traceback (most recent call last):
11:14:22    FATAL -   File "/builds/slave/test/scripts/mozharness/base/script.py", line 1048, in run
11:14:22    FATAL -     self.run_action(action)
11:14:22    FATAL -   File "/builds/slave/test/scripts/mozharness/base/script.py", line 990, in run_action
11:14:22    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
11:14:22    FATAL -   File "/builds/slave/test/scripts/mozharness/base/script.py", line 931, in _possibly_run_method
11:14:22    FATAL -     return getattr(self, method_name)()
11:14:22    FATAL -   File "scripts/scripts/b2g_emulator_unittest.py", line 333, in run_tests
11:14:22    FATAL -     cmd = self._query_abs_base_cmd(suite)
11:14:22    FATAL -   File "scripts/scripts/b2g_emulator_unittest.py", line 270, in _query_abs_base_cmd
11:14:22    FATAL -     option = option % str_format_values
11:14:22    FATAL - KeyError: 'test_plugin_path'
11:14:22    FATAL - Exiting -1
Created attachment 785134 [details] [diff] [review]
mozharness should pass test-plugin-path to runxpcshelltests.py

Problem was I made the change to the b2g script as well, but it turns out that
one is not set up in the same way.

Please don't land it yet, need to investigate a failure that popped up with this
patch applied.
Attachment #785134 - Flags: review?(rail)
(Assignee)

Updated

5 years ago
Attachment #784096 - Attachment is obsolete: true

Updated

5 years ago
Attachment #785134 - Flags: review?(rail) → review+
(Assignee)

Updated

5 years ago
No longer blocks: 899857
Depends on: 899857
The change in bug 899857 will allow the transition to passing in --test-plugin-path.
You can retrigger xpcshell tests on cedar to test this change out.
Just did, thanks!
Comment on attachment 785134 [details] [diff] [review]
mozharness should pass test-plugin-path to runxpcshelltests.py

Merged to production.
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.