Closed Bug 900274 Opened 7 years ago Closed 7 years ago

Mark content/base/src as FAIL_ON_WARNINGS

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: dholbert, Assigned: Six)

References

Details

Attachments

(1 file)

content/base/src is warning-free on my system (64-bit linux debug), and nearly warning-free on other platforms.

Filing this bug on marking it as FAIL_ON_WARNINGS.
Depends on: 900277
This should be what dholbert expects
Assignee: nobody → six.dsn
Status: NEW → ASSIGNED
Attachment #784330 - Flags: review?(bugs)
Attachment #784330 - Flags: review?(bugs) → review+
Comment on attachment 784330 [details] [diff] [review]
Mark content/base/src as FAIL_ON_WARNINGS in Makefile.in

Yup, thanks!

As of the last few weeks, changes to makefiles need review from a Build System module-owner/peer, too. Tagging gps.

Also, this of course shouldn't land until it gets a green Try run (indicating that all the warnings are actually fixed -- which are largely but not quite all tracked in dependent bugs).

Here's my latest try push with this patch-stack, showing that we've got at least one warning left on windows to file/fix:  https://tbpl.mozilla.org/?tree=Try&rev=1e171b6fe9cc
Attachment #784330 - Flags: review?(gps)
Comment on attachment 784330 [details] [diff] [review]
Mark content/base/src as FAIL_ON_WARNINGS in Makefile.in

Review of attachment 784330 [details] [diff] [review]:
-----------------------------------------------------------------

I should probably make FAIL_ON_WARNINGS an exception to the build peer review policy.
Attachment #784330 - Flags: review?(gps) → review+
Depends on: 901529
No longer blocks: 900260
Depends on: 900260
No longer blocks: 900209
Depends on: 900209
No longer blocks: 900246
Depends on: 900246
Depends on: 901645
Try run with the fixes for all the (current) bugs that this depends on:
 https://tbpl.mozilla.org/?tree=Try&rev=a62d63fa1859
OK, bug 900260 (the last bug that blocks this) just landed, so as long as that sticks & no other warnings were introduced there in the last ~day, this should be good to land (or mark as checkin-needed).

Here's one last try run, with current mozilla-inbound plus the attached patch here, as a final sanity-check: https://tbpl.mozilla.org/?tree=Try&rev=6912d4c45cd3
Try looks good! (just one unrelated orange build)

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/8c7abf287224
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/8c7abf287224
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.