900274 - Mark content/base/src as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

content/base/src is warning-free on my system (64-bit linux debug), and nearly warning-free on other platforms.

Filing this bug on marking it as FAIL_ON_WARNINGS.

Comment 1

[Arnaud Sourioux [:Six]]

Attachment: Mark content/base/src as FAIL_ON_WARNINGS in Makefile.in

This should be what dholbert expects

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 784330 [details] [diff] [review]
Mark content/base/src as FAIL_ON_WARNINGS in Makefile.in

Yup, thanks!

As of the last few weeks, changes to makefiles need review from a Build System module-owner/peer, too. Tagging gps.

Also, this of course shouldn't land until it gets a green Try run (indicating that all the warnings are actually fixed -- which are largely but not quite all tracked in dependent bugs).

Here's my latest try push with this patch-stack, showing that we've got at least one warning left on windows to file/fix:  https://tbpl.mozilla.org/?tree=Try&rev=1e171b6fe9cc

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 784330 [details] [diff] [review]
Mark content/base/src as FAIL_ON_WARNINGS in Makefile.in

Review of attachment 784330 [details] [diff] [review]:
-----------------------------------------------------------------

I should probably make FAIL_ON_WARNINGS an exception to the build peer review policy.

Comment 4

[Daniel Holbert [:dholbert]]

Try run with the fixes for all the (current) bugs that this depends on:
 https://tbpl.mozilla.org/?tree=Try&rev=a62d63fa1859

Comment 5

[Daniel Holbert [:dholbert]]

OK, bug 900260 (the last bug that blocks this) just landed, so as long as that sticks & no other warnings were introduced there in the last ~day, this should be good to land (or mark as checkin-needed).

Here's one last try run, with current mozilla-inbound plus the attached patch here, as a final sanity-check: https://tbpl.mozilla.org/?tree=Try&rev=6912d4c45cd3

Comment 6

[Daniel Holbert [:dholbert]]

Try looks good! (just one unrelated orange build)

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/8c7abf287224

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8c7abf287224