Closed Bug 900277 Opened 6 years ago Closed 6 years ago

Element.cpp(2480) : warning C4355: 'this' : used in base member initializer list

Categories

(Core :: DOM: Core & HTML, defect)

All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Windows hits a warning for using "this" in init list (but we're just using 'this' to initialize a pointer value, so it's safe):
{
e:/builds/moz2_slave/try-w32-0000000000000000000000/build/content/base/src/Element.cpp(2480) : warning C4355: 'this' : used in base member initializer list
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=25991998&tree=Try

The ALLOW_THIS_IN_INITIALIZER_LIST macro suppresses that warning & should take care of this.
OS: Linux → Windows 7
Hardware: x86_64 → All
Attached patch fix v1 (obsolete) — Splinter Review
Attachment #784083 - Flags: review?(bugs)
Comment on attachment 784083 [details] [diff] [review]
fix v1

Please use MOZ_THIS_IN_INITIALIZER_LIST instead.
Ah, thanks -- I thought I remembered you adding a MOZ_ macro, but I couldn't remember the name. (I mistakenly grepped for MOZ_ALLOW_THIS and didn't find it)
Attachment #784083 - Attachment is obsolete: true
Attachment #784083 - Flags: review?(bugs)
Attachment #784222 - Flags: review?(bugs)
Attachment #784222 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/fx-team/rev/80b6d90df831
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/80b6d90df831
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla25
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.