Element.cpp(2480) : warning C4355: 'this' : used in base member initializer list

RESOLVED FIXED in mozilla25

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla25
All
Windows 7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Windows hits a warning for using "this" in init list (but we're just using 'this' to initialize a pointer value, so it's safe):
{
e:/builds/moz2_slave/try-w32-0000000000000000000000/build/content/base/src/Element.cpp(2480) : warning C4355: 'this' : used in base member initializer list
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=25991998&tree=Try

The ALLOW_THIS_IN_INITIALIZER_LIST macro suppresses that warning & should take care of this.
(Assignee)

Updated

5 years ago
Blocks: 187528
(Assignee)

Updated

5 years ago
OS: Linux → Windows 7
Hardware: x86_64 → All
(Assignee)

Comment 1

5 years ago
Created attachment 784083 [details] [diff] [review]
fix v1
Attachment #784083 - Flags: review?(bugs)
(Assignee)

Updated

5 years ago
Blocks: 900274
Comment on attachment 784083 [details] [diff] [review]
fix v1

Please use MOZ_THIS_IN_INITIALIZER_LIST instead.
(Assignee)

Comment 3

5 years ago
Created attachment 784222 [details] [diff] [review]
fix v2 (using MOZ_ macro)

Ah, thanks -- I thought I remembered you adding a MOZ_ macro, but I couldn't remember the name. (I mistakenly grepped for MOZ_ALLOW_THIS and didn't find it)
Attachment #784083 - Attachment is obsolete: true
Attachment #784083 - Flags: review?(bugs)
Attachment #784222 - Flags: review?(bugs)

Updated

5 years ago
Attachment #784222 - Flags: review?(bugs) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/80b6d90df831
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/80b6d90df831
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.