900277 - Element.cpp(2480) : warning C4355: 'this' : used in base member initializer list

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

Windows hits a warning for using "this" in init list (but we're just using 'this' to initialize a pointer value, so it's safe):
{
e:/builds/moz2_slave/try-w32-0000000000000000000000/build/content/base/src/Element.cpp(2480) : warning C4355: 'this' : used in base member initializer list
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=25991998&tree=Try

The ALLOW_THIS_IN_INITIALIZER_LIST macro suppresses that warning & should take care of this.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 784083 [details] [diff] [review]
fix v1

Please use MOZ_THIS_IN_INITIALIZER_LIST instead.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v2 (using MOZ_ macro)

Ah, thanks -- I thought I remembered you adding a MOZ_ macro, but I couldn't remember the name. (I mistakenly grepped for MOZ_ALLOW_THIS and didn't find it)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/80b6d90df831

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/80b6d90df831