Last Comment Bug 900286 - Unregress Talos tests after landing Intl
: Unregress Talos tests after landing Intl
Status: RESOLVED INVALID
:
Product: Core
Classification: Components
Component: JavaScript: Internationalization API (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
: Jeff Walden [:Waldo] (remove +bmo to email)
Mentors:
Depends on: 900292 919872
Blocks: 853301
  Show dependency treegraph
 
Reported: 2013-07-31 17:23 PDT by Till Schneidereit [till]
Modified: 2014-02-12 16:36 PST (History)
8 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description User image Till Schneidereit [till] 2013-07-31 17:23:04 PDT
From 853301 bug comment 32:

"Similar to the previous landing, this regressed Ts by ~25ms, tpaint by about 10ms, and increased various memory counters.  Possible clue: "Tp5 No Network Row Major MozAfterPaint (Main Startup File IO Bytes)" regressed by 34% (about 10MB).

https://groups.google.com/d/topic/mozilla.dev.tree-management/o0klAW2kxj8/discussion

If this patch stays in, we'll need follow-up bugs to fix the regressions.  They should be nominated for tracking-firefox25."
Comment 1 User image Alex Keybl [:akeybl] 2013-10-01 09:50:37 PDT
Naveed, how do you plan to address this? Should we worry about this in the FF25 timeframe? If so, do we have alternatives such as disabling part of bug 853301?
Comment 2 User image Till Schneidereit [till] 2013-10-01 10:03:44 PDT
(In reply to Alex Keybl [:akeybl] from comment #1)
> Naveed, how do you plan to address this? Should we worry about this in the
> FF25 timeframe? If so, do we have alternatives such as disabling part of bug
> 853301?

This will pretty much be fixed once bug 919872 lands.
Comment 3 User image Jeff Walden [:Waldo] (remove +bmo to email) 2013-10-01 13:58:04 PDT
Also, if I'm not mistaken, the original regression was backed out before branch uplift, so technically there's nothing in any tree to unregress.  Only once Intl is enabled in desktop builds could there possibly be any regression -- but with bug 919872 landed, I'm fairly sure there'll be no regression any more.
Comment 4 User image :Gavin Sharp [email: gavin@gavinsharp.com] 2013-10-02 10:56:54 PDT
The landing management in bug 853301 has not been great. As I understand it, bug 853301 comment 41 was a trunk disabling, and bug 853301 comment 64 re-enabled building of it, but doesn't expose it (so still no Talos impact). So 25 up to trunk are not "affected", and we don't need to track this for 25.
Comment 5 User image Gordon P. Hemsley [:GPHemsley] 2014-02-09 06:10:39 PST
Mass-moving existing Intl-related bugs to the new Core :: JavaScript: Internationalization API component.

If you think this bug has been moved in error, feel free to move it back to Core :: JavaScript Engine.

[Mass change filter: core-js-intl-api-move]
Comment 6 User image :Gavin Sharp [email: gavin@gavinsharp.com] 2014-02-12 16:36:20 PST
I don't think this is relevant anymore.

Note You need to log in before you can comment on or make changes to this bug.