Closed Bug 900316 Opened 9 years ago Closed 9 years ago

non-gsm devices will not be able to upload data

Categories

(Core :: DOM: Geolocation, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26
Tracking Status
firefox25 --- wontfix
firefox26 --- fixed

People

(Reporter: dougt, Assigned: cpeterson)

Details

Attachments

(1 file, 1 obsolete file)

I am not sure why we bail early, but it means that we will not collect wifi data from tablets.


http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoApp.java#2522
OS: Mac OS X → Android
Hardware: x86 → All
Attached patch include-non-gsm-devices.patch (obsolete) — Splinter Review
1. Allow non-GSM devices to submit geolocation reports.
2. Don't submit geolocation report after a JSONException because the report is probably incomplete or malformed.
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
Attachment #784658 - Flags: review?(blassey.bugs)
Attachment #784658 - Flags: review?(blassey.bugs) → review+
Comment on attachment 784658 [details] [diff] [review]
include-non-gsm-devices.patch

"int radioType = getCellInfo(cellInfo)" returns the result of "tm.getPhoneType()" which is documented here: http://developer.android.com/reference/android/telephony/TelephonyManager.html#getPhoneType%28%29

In addition to GSM, it can be of type CDMA, None or SIP. We do want to know about the CDMA case, so we need one more else statement with something like:

if (radioType == TelephonyManager.PHONE_TYPE_CDMA)
    locInfo.put("radio", "cdma");

For the None and SIP cases, it's fine to just omit the "radio" record.
Attachment #784658 - Flags: review-
Patch v2 includes the "radio" property for GSM and CDMA phones (and logs a warning for unknown PHONE_TYPE values).
Attachment #784658 - Attachment is obsolete: true
Attachment #786040 - Flags: review?(hschlichting)
Attachment #786040 - Flags: review?(blassey.bugs)
Attachment #786040 - Flags: review?(hschlichting) → review+
Attachment #786040 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/6d9203ca852e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.