900316 - non-gsm devices will not be able to upload data

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Doug Turner (:dougt)]

I am not sure why we bail early, but it means that we will not collect wifi data from tablets.


http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoApp.java#2522

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: include-non-gsm-devices.patch

1. Allow non-GSM devices to submit geolocation reports.
2. Don't submit geolocation report after a JSONException because the report is probably incomplete or malformed.

Comment 2

[Hanno Schlichting]

Comment on attachment 784658 [details] [diff] [review]
include-non-gsm-devices.patch

"int radioType = getCellInfo(cellInfo)" returns the result of "tm.getPhoneType()" which is documented here: http://developer.android.com/reference/android/telephony/TelephonyManager.html#getPhoneType%28%29

In addition to GSM, it can be of type CDMA, None or SIP. We do want to know about the CDMA case, so we need one more else statement with something like:

if (radioType == TelephonyManager.PHONE_TYPE_CDMA)
    locInfo.put("radio", "cdma");

For the None and SIP cases, it's fine to just omit the "radio" record.

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: include-non-gsm-devices-v2.patch

Patch v2 includes the "radio" property for GSM and CDMA phones (and logs a warning for unknown PHONE_TYPE values).

Comment 4

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d9203ca852e

Comment 5

[[Back July 11] Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/6d9203ca852e