B2G RIL: Add PUK state for nck, spck, and cck

RESOLVED FIXED in mozilla26

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: allstars, Unassigned)

Tracking

Trunk
mozilla26
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 5 obsolete attachments)

In Bug 849757 we have added 'spck' and 'cck' card state when the SIM card is locked in personalization state. But we didn't add PUK for these locks.
So Gaia side couldn't know the SIMcard is in nck-puk, spck-puk, cck-puk state.

This bug is filed to fix these.
Created attachment 784767 [details] [diff] [review]
Part 3: RIL and tests.
Created attachment 784769 [details] [diff] [review]
Part 2: DOM
Attachment #784765 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #784764 - Flags: review?(vyang)
Created attachment 784842 [details] [diff] [review]
Part 1: IDL v2.
Attachment #784764 - Attachment is obsolete: true
Attachment #784764 - Flags: review?(vyang)
Attachment #784842 - Flags: review?(vyang)
Created attachment 784843 [details] [diff] [review]
Part 2: RIL and test case. v2
Attachment #784767 - Attachment is obsolete: true
Attachment #784769 - Attachment is obsolete: true

Updated

5 years ago
Blocks: 900885
Attachment #784842 - Flags: review?(vyang) → review+
(Assignee)

Updated

5 years ago
Attachment #784843 - Flags: review?(vyang)
Comment on attachment 784843 [details] [diff] [review]
Part 2: RIL and test case. v2

Review of attachment 784843 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +1039,5 @@
>    enterDepersonalization: function enterDepersonalization(options) {
>      Buf.newParcel(REQUEST_ENTER_NETWORK_DEPERSONALIZATION_CODE, options);
>      Buf.writeUint32(options.type);
> +    if (options.lockType.endsWith("Puk")) {
> +      Buf.writeString(options.puk);

Let's move these determinant logic to the callee, let |enterDepersonalization| accept three parameters -- type, pin, and options.
Attachment #784843 - Flags: review?(vyang)
Created attachment 785636 [details] [diff] [review]
Part 2: RIL and test case. v3
Attachment #784843 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #785636 - Flags: review?(vyang)
(Assignee)

Updated

5 years ago
Attachment #784842 - Flags: superreview?(jonas)
Attachment #784842 - Flags: superreview?(jonas) → superreview+
Comment on attachment 785636 [details] [diff] [review]
Part 2: RIL and test case. v3

Review of attachment 785636 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)
Attachment #785636 - Flags: review?(vyang) → review+
Backed out for the Marionette failures discussed in bug 901897.
https://hg.mozilla.org/integration/b2g-inbound/rev/cd6bda58b682
Error message: 
09:49:11     INFO -  AssertionError: See errors below and more information in Bug 880643
09:49:11     INFO -  ril_consts.js: line 2368, col 36, ['nck'] is better written in dot notation.
09:49:11     INFO -  ril_consts.js: line 2369, col 36, ['cck'] is better written in dot notation.
09:49:11     INFO -  ril_consts.js: line 2370, col 36, ['spck'] is better written in dot notation.
09:49:11     INFO -  ril_consts.js: line 2371, col 36, ['nckPuk'] is better written in dot notation.
09:49:11     INFO -  ril_consts.js: line 2372, col 36, ['cckPuk'] is better written in dot notation.
09:49:11     INFO -  ril_consts.js: line 2373, col 36, ['spckPuk'] is better written in dot notation.
09:49:11     INFO -  TEST-UNEXPECTED-FAIL | 



I'll create a Part 3 patch to fix this.
Created attachment 786770 [details] [diff] [review]
Part 3: To fix style nits.
Attachment #786770 - Flags: review?(vyang)
Attachment #786770 - Flags: review?(vyang) → review+
https://hg.mozilla.org/mozilla-central/rev/6f84ea80219d
https://hg.mozilla.org/mozilla-central/rev/4bb87898165a
https://hg.mozilla.org/mozilla-central/rev/daaaa9227b48
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.