900321 - B2G RIL: Add PUK state for nck, spck, and cck

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In Bug 849757 we have added 'spck' and 'cck' card state when the SIM card is locked in personalization state. But we didn't add PUK for these locks.
So Gaia side couldn't know the SIMcard is in nck-puk, spck-puk, cck-puk state.

This bug is filed to fix these.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: IDL

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: DOM

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: RIL and tests.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: DOM

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: IDL v2.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: RIL and test case. v2

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 784843 [details] [diff] [review]
Part 2: RIL and test case. v2

Review of attachment 784843 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +1039,5 @@
>    enterDepersonalization: function enterDepersonalization(options) {
>      Buf.newParcel(REQUEST_ENTER_NETWORK_DEPERSONALIZATION_CODE, options);
>      Buf.writeUint32(options.type);
> +    if (options.lockType.endsWith("Puk")) {
> +      Buf.writeString(options.puk);

Let's move these determinant logic to the callee, let |enterDepersonalization| accept three parameters -- type, pin, and options.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: RIL and test case. v3

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 785636 [details] [diff] [review]
Part 2: RIL and test case. v3

Review of attachment 785636 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5fd0b863fac7
https://hg.mozilla.org/integration/b2g-inbound/rev/ede868d47878

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Backed out for the Marionette failures discussed in bug 901897.
https://hg.mozilla.org/integration/b2g-inbound/rev/cd6bda58b682

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Error message: 
09:49:11     INFO -  AssertionError: See errors below and more information in Bug 880643
09:49:11     INFO -  ril_consts.js: line 2368, col 36, ['nck'] is better written in dot notation.
09:49:11     INFO -  ril_consts.js: line 2369, col 36, ['cck'] is better written in dot notation.
09:49:11     INFO -  ril_consts.js: line 2370, col 36, ['spck'] is better written in dot notation.
09:49:11     INFO -  ril_consts.js: line 2371, col 36, ['nckPuk'] is better written in dot notation.
09:49:11     INFO -  ril_consts.js: line 2372, col 36, ['cckPuk'] is better written in dot notation.
09:49:11     INFO -  ril_consts.js: line 2373, col 36, ['spckPuk'] is better written in dot notation.
09:49:11     INFO -  TEST-UNEXPECTED-FAIL | 



I'll create a Part 3 patch to fix this.

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: To fix style nits.

Comment 14

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Try result with Part 3 :
https://tbpl.mozilla.org/?tree=Try&rev=a2037f5718a5

Comment 15

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/6f84ea80219d
https://hg.mozilla.org/integration/b2g-inbound/rev/4bb87898165a
https://hg.mozilla.org/integration/b2g-inbound/rev/daaaa9227b48

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6f84ea80219d
https://hg.mozilla.org/mozilla-central/rev/4bb87898165a
https://hg.mozilla.org/mozilla-central/rev/daaaa9227b48