900326 - [Buri][Crash report]The Report button is no useful when tap it

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.171
 Firefox os  v1.1
 Mozilla build ID:20130722070207
 
 Created an attachment (id=473147)
 adb log
 
 DEFECT DESCRIPTION:
  The Report button is no useful when tap it
  REPRODUCING PROCEDURES:
  1.go to settings 
 
  2.go to Improve Firefox OS 
 
  3.select "Ask each time" 
 
  4.crash either b2g or the app by using kill -11 <process id>
  
  5.Tap the button"Report",but it is no useful.It enter the app behind the Report->KO
  EXPECTED BEHAVIOUR:
  The button Report should be useful
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
  Mid
  REPRODUCING RATE:
  5/5
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: adb log

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: pic

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Kairo is this a regression?  Can you help get eyes on this to investigate?

Comment 6

[Robert Kaiser]

I'm not sure what "the button is not useful" actually means.

Comment 7

[sync-1]

Hello Kaiser, 
   The 'Report' unable to be pressed.

Comment 8

[Robert Kaiser]

Well, if it works as it should, there still is nothing user-visible happening there. Are you sure that no crash report is actually submitted at that point? There is no user interface that would tell you, it needs a look into the "Crash Reports" directories on disk.

Comment 9

[bhavana bajaj [:bajaj]]

Adding our QA to confirm behavior.

There should be a way to ensure crash reports are being sent, can someone help with exact steps here.

Comment 10

[Natalya Kot [:nkot]]

The user can ensure if crash reports are being sent by going to data/b2g/mozilla/Crash Reports folder.

1. Crash reports are being saved successfully in the folder "submitted" when sending reports from notification screen "Would you like to send Mozilla a report about the crash..." using a button "Send Report."  

2. This bug is happening when sending reports from the banner "Homescreen just crash" using a button "Report." 
I was able to reproduce the behavior when tapping "Report" button results in launching the app whichever was behind. 
Talking about the actual crash reports here, they are being sent but saved in data/b2g/mozilla/Crash Reports/pending folder instead of submitted one.

*Please note that WiFi was enabled while tested both scenarios 

Build ID: 20130805071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a2a9b89ef5ee
Gaia: 45f6a739b09292e16717fb21003386c914ca29c2
Platform Version: 18.1

Comment 11

[Preeti Raghunath(:Preeti)]

leo+, need to be able to see crash reports.

Comment 12

[sync-1]

Hello, 
    Have any news about this PR?

Comment 13

[sync-1]

Hello kairo, 
    Have any news about this PR?

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

Tim, does it fall under your team? Thanks

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Investigating.

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

By information given by comment 10, I was suspecting there was a CSS rule being mistakenly added. However I am not be able to find it by inspecting the DOM from Firefox Desktop, so there is no way Gaia would have cause this kind of problem.

I can produce this problem on Firefox Desktop, and the touch event seems to be mistakenly delayed for some reason.

I am kicking this to general to see if people could investigating it on the Gecko side.

Comment 17

[Joe Cheng [:jcheng] (please needinfo)]

dbaron, is this something that you can help with? Thanks

Comment 18

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Could you explain what you think the Gecko problem is?

Comment 19

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to David Baron [:dbaron] (needinfo? me; away Aug 28 - Sep 3) from comment #18)
> Could you explain what you think the Gecko problem is?

I cannot find a |point-events: none| rule that is being applied on the button on banner nor any of its parents, so I ruled out that. My STR on Mac Firefox is as follows:

1. Clone Gaia, run DEBUG=1 make, launch Firefox with the generated profile.
2. System app will be launched. Go to the JS console on the right and unlock the device with |LockScreen.unlock();|
3. Trick SystemBanner into display our own message by run the following on the console 

SystemBanner.show('Hello!', { label: 'Click me', callback: function () { console.log('clicked'); }, dismiss: function() { console.log('dismissed'); } });

4. Attempt to click the button when the banner is shown

Expected result:

1. When you clicked on the button, console prints "clicked". Nothing will be shown on the UI though.

Actual result:

1. Console prints nothing when I clicked on the button (I am sure the button is clicked because I can see the active style of the button)
2. When the CSS animation finishes, home screen receives the click event and launch the Contact app on it's dock. This does not happen as soon as I click on the button.

My guts tell me the root cause is on the platform because there seems to be multiple factors involved. One being the CSS animation (we turned on async animation on B2G), the other being that homescreen is a OOP frame.

Comment 20

[Robert Kaiser]

This button is not supposed to do anything really user-visible. Sending a crash report happens in the background. What we could do is give some feedback on the button, i.e. changing it from "Send" to "Sending" or something once it has been tapped. From all I know, the button does the right thing, i.e. it sends the crash report, so it is functional. It just doesn't give any feedback to the user about that.

Comment 21

[Preeti Raghunath(:Preeti)]

Kairo,

Does this issue even exist? Please confirm.

Comment 22

[Robert Kaiser]

(In reply to Preeti Raghunath(:Preeti) from comment #21)
> Kairo,
> 
> Does this issue even exist? Please confirm.

The issue of the button doing nothing does not exist, AFAIK. The actual issue (that I think we should address at some point) is that there's no user feedback on tapping the button.

Comment 23

[Preeti Raghunath(:Preeti)]

since workaround is available per comment 10.

Comment 24

[Preeti Raghunath(:Preeti)]

Jet,

Can you please investigate based on comment 19?

Comment 25

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Where does the gaia code for this button live?

Comment 26

[sync-1]

Have any news about this issue?

Comment 27

[sync-1]

It's not ok in 17A-2

Comment 28

[Andrew Overholt [:overholt]]

(In reply to David Baron [:dbaron] (needinfo? me) from comment #25)
> Where does the gaia code for this button live?

Just a guess based on git grep in my gaia checkout:  apps/system/js/crash_reporter.js.

Comment 29

[Preeti Raghunath(:Preeti)]

dbaron,

Please investigate based on :overholt's clue.

Comment 30

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'm treating the above request as low priority given the amount of confusion here about what's supposed to be happening.  (It's also not clear to me if comment 19 is related to this bug at all, or if it should be a separate bug report.)

Comment 31

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Though I guess comment 19 is related because of the showBanner function in the file in comment 28.

Comment 32

[Preeti Raghunath(:Preeti)]

Sync-1,

Please comment if this bug is a show stopper for 1.1

Comment 33

[sync-1]

Preeti,

Now it is not a show stopper for 1.1, please solve it in V1.2.
Thanks.

Comment 34

[Jason Smith [:jsmith]]

Moving to koi per comment 33

Comment 35

[Preeti Raghunath(:Preeti)]

Andrew,

Can you please if this is a DOM issue?

Comment 36

[Preeti Raghunath(:Preeti)]

Minus,

Since this is a low risk from UX perspective. The default setting anyway doesn't display this behavior.

Comment 37

[Andrew Overholt [:overholt]]

This is a layout issue IMO but since it's koi-, I'm taking myself off ni?.

Comment 38

[BMO Automation]

Firefox OS is not being worked on