Enable customization per target device of resolution for FB images

RESOLVED FIXED

Status

Firefox OS
Gaia::Contacts
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jose Manuel Cantera, Assigned: fcampo)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Details

(Whiteboard: QARegressExclude)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We need to add two parameters to communications_services.json in order to define a default base value for the resolution of the FB images to be shown both in contact list and contact details. The default value should be 120 and 200 respectively for not breaking inari / ikura devices.

For leo devices we will be talking to LG / TEF in order to finer tune this value according to the dpi provided by those devices. 

This should be marked as leo+ as per conversation with Daniel.
(Reporter)

Updated

5 years ago
blocking-b2g: --- → leo?
Triage - can we understand what the user impact here is?
Does taking this bug provide better resolution pictures for contacts?
Is anything broken if we dont take this?

Thanks
Flags: needinfo?(jmcf)
(Reporter)

Comment 3

5 years ago
Comment on attachment 784339 [details] [review]
Lin kto PR - https://github.com/mozilla-b2g/gaia/pull/11295

provided the latest nits are fixed. 

thanks!
Attachment #784339 - Flags: review?(jmcf) → review+
(Reporter)

Comment 4

5 years ago
(In reply to Wayne Chang [:wchang] from comment #2)
> Triage - can we understand what the user impact here is?
> Does taking this bug provide better resolution pictures for contacts?

Yes, particularly in leo devices we have found that default values are not enough, so the idea is to allow OEM / partners to customize these values. 

> Is anything broken if we dont take this?

Nothing, but a bad UX and bad user perception of the product

> 
> Thanks
Flags: needinfo?(jmcf)
(Assignee)

Comment 5

5 years ago
Merged on master https://github.com/mozilla-b2g/gaia/commit/4b347e4e39b1716b68463dccc63c1b3eb49158b3

waiting for the leo+ for setting the uplift flag
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Go ahead with uplift to v1.1
blocking-b2g: leo? → leo+
I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 4b347e4e39b1716b68463dccc63c1b3eb49158b3
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(fernando.campo)
(Assignee)

Comment 8

5 years ago
uplifted 4c1a205

Thanks to all
Flags: needinfo?(fernando.campo)
status-b2g18: --- → fixed
v1.1.0hd: 4c1a20570e20f64782ba170c14604395c48f7381
status-b2g-v1.1hd: --- → fixed

Updated

5 years ago
Whiteboard: QARegressExclude
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.