900379 - [System][ValueSelector] Tap on an option of the <select> returns directly the value without the 'OK', so the 'OK' is useless.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[isabelrios]

Unagi device 01/08 v1-train build:
STR
1. Create a new message
2. Write some text
3. Tap on '+' icon
4. Select a contact with at least two phone numbers associated
5. Select one of the numbers
6. Tap on 'OK'

EXPECTED
After selecting a number to be added into the 'To' field, user should be able to tap on 'OK'

ACTUAL
When a number has been selected, the screen is automatically closed an user is taken back to edit message screen with the number already into the 'To' field.

This is a follow up bug895817, case #1. Marking as leo?
According to the building block showing several numbers, it should be possible to tap on 'OK' button

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

If this a regression from v1.0.1 as well?

Comment 2

[Natalya Kot [:nkot]]

There is no option to send an SMS to multiple recipients on v1.0.1, instead of "+" icon there is "contact" icon to select recipient from the contacts

Having said that, the issue reproduces exactly the same when using "contact" icon:
 - select a contact with more than one number
 - select one of the numbers 
==> the screen automatically closes an user is taken back to edit message screen with the number already into the 'To' field

Unagi
Build ID: 20130729070220
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0
Gaia: 054cdc27404e2daca91d3065d9783681032b2151
Platform Version: 18.0

Comment 3

[Wayne Chang [:wchang]]

Triage - not blocking based on comment 0 description.
Users are still able to select one number from a multi-number contact and the selected number is correctly added to the "To" field despite not being confirmed after selecting.

Comment 4

[Rick Waldron [:rwaldron]]

HTML5_SMS-MMSUserStorySpecifications_20130503_V8.0.pdf, page 6, #04:
 - Add contact from contact list CTA
   - contact list is opened (refer to wireframe 'SMS : contact list' in wireframe pack 'HTML5_SMS_20121212_R2S1_V8.0')

HTML5_SMS_20121212_R2S1_V8.0.pdf, page 11, #03

  - If a contact has more than one phone number irrespective of 'type' of phone number
    - clicking the contact in the contact list opens wireframe 'SMS : contact list phone numbers'


SMS : contact list phone numbers, HTML5_SMS_20121212_R2S1_V8.0.pdf, page 12, #01

This is the missing step. See attachments

Comment 5

[Rick Waldron [:rwaldron]]

Attachment: HTML5_SMS_20121212_R2S1_V8.0-page-11.png

Comment 6

[Rick Waldron [:rwaldron]]

Attachment: HTML5_SMS_20121212_R2S1_V8.0-page-12.png

Comment 7

[Borja Salguero [:borjasalguero]]

+1 Rick. Thanks for the info! As this week Im gonna take a look to Contacts, Im gonna try to solve this as well. Thanks!

Comment 8

[Rick Waldron [:rwaldron]]

That's great Borja, thanks for jumping on this :)

Comment 9

[Borja Salguero [:borjasalguero]]

This issue is not related with Contacts or SMS. Taking a look to the code of 'value_selector.js' in System, I've just realized that when tapping different options within the '<select>' the value is returned automatically, so 'Ok' has no sense (due to the action was executed, regardless if the action was confirmed or not).
I don't know if this is a common pattern in the OS, but If we need to change this we will need to take into account that this change will affect the whole OS.
STR for testing ---> https://bugzilla.mozilla.org/show_bug.cgi?id=900379#c0

Ayman, I've seen this is part of your WF, could you take a look to this? Probably we need to take this out of the spec of comms as is part of System. 
On the other hand, Could you add ni? to the right System UX? Thanks!

Comment 10

[ayman maat :maat]

(In reply to Borja Salguero [:borjasalguero] from comment #9) 
> Ayman, I've seen this is part of your WF, could you take a look to this?
> Probably we need to take this out of the spec of comms as is part of System. 
> On the other hand, Could you add ni? to the right System UX? Thanks!

I am following what i understand to be the building blocks (unless i have misinterpreted).
passing ni? to Stephany who will redirect this bug to the correct UX practitioner.

Comment 11

[Stephany Wilkes]

Thank you, Ayman. Flagging Harly, Building Blocks owner.

Comment 12

[Harly Hsu[:harly]]

This is one of the things I have pointed out during the UX workweek, and in the building blocks document website(https://developer.mozilla.org/en-US/Apps/Design/Building_Blocks/Value_selector?redirectlocale=en-US&redirectslug=Web%2FApps%2FGraphics_and_UX%2FBuilding_Blocks%2FValue_selector), it is defined that the single value selector should have a cancel button instead of ok button. Moreover, when user selects a value, the system should close the value selector and return to the previous page with the value applied. Could anyone from the development side have a look to see if it can be modified according to the building blocks document?

Comment 13

[Borja Salguero [:borjasalguero]]

Alive is the owner of System, where the code of the 'Value Selector' is. Alive, could you sync. with Harly about this issue? Thanks!

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

This is an old issue and it's intended from long time ago.
I agree it's strange so I am willing to change it.

c.c. Rudy for he is the one implementing this

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

Rudy could you find out the discussion for value selector behavior?

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

The current behavior comes with a long story behind it.
You could read Bug 819619 and the attached mail thread (for discussion) and the related bugs for all the debates on what behavior is correct.

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Rudy Lu [:rudyl] from comment #16)
> The current behavior comes with a long story behind it.
> You could read Bug 819619 and the attached mail thread (for discussion) and
> the related bugs for all the debates on what behavior is correct.

As Rudy said, Borja, you are welcome to challenge the behavior and revive the discussion.

Comment 18

[Loli (:lolimartinezcr)]

master 16/01/2014
Buid ID: 20140116105426
Platform version:29.0a1
Git commit info: b6784673

Other scenario invalid is:
Pre-resquisites:
DSDS device

Steps:
1. Tap "Settings".
2. Tap "SIM manager".
3. In data select a SIM different to selected (NO press "OK" button)
4. Press "home" button 
5. Tap "Settings"

Actual result:
Screen: The current data transfer will be suspended. Continue anyway?"

Expected result:
Settings screen, in data: fist sim selected.

Comment 19

[BMO Automation]

Firefox OS is not being worked on