WindowsDllNopSpacePatcher doesn't work on Windows 8

RESOLVED FIXED in mozilla25

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla25
x86
Windows 8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

On Windows 8, VirtualAlloc code is the following.

0:000> u kernel32!VirtualAllocStub-5
KERNEL32!VerLanguageNameWStub+0xc:
752f58f3 cc              int     3
752f58f4 cc              int     3
752f58f5 cc              int     3
752f58f6 cc              int     3
752f58f7 cc              int     3
KERNEL32!VirtualAllocStub:
752f58f8 8bff            mov     edi,edi
752f58fa 55              push    ebp
752f58fb 8bec            mov     ebp,esp
752f58fd 5d              pop     ebp
752f58fe ff25a8063575    jmp     dword ptr [KERNEL32!_imp__VirtualAlloc (753506a8)]
752f5904 cc              int     3
752f5905 cc              int     3
752f5906 cc              int     3
752f5907 cc              int     3
752f5908 cc              int     3

WindowsDllNopSpacePatcher expects NOP (0x90) around function, but it is INT 3(0xcc).  So we have to consider 0xcc too to use WindowsDllNopSpacePatcher.

Also, WindowsDllNopSpacePatcher is for Bug 742491.
Attachment #784324 - Flags: review?(ehsan)

Updated

5 years ago
Attachment #784324 - Flags: review?(ehsan) → review+

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5603000cc1bb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.