Closed
Bug 900446
Opened 11 years ago
Closed 11 years ago
Pick Contact Activity filtered by webcontact/tel should return filtered tel info and contact data
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:koi+)
RESOLVED
FIXED
blocking-b2g | koi+ |
People
(Reporter: jmcf, Assigned: fcampo)
References
Details
(Whiteboard: [u=commsapps-user c=contacts p=0])
Attachments
(1 file, 1 obsolete file)
We need that the webcontact/tel activity returns detailed contact information, currently only the tel number and the name are provided. We need to provide, the contact names, the full tel field array (filtering out the tels not seelcted). Finally, we need to experiment with the delay experimented if we also transfer the blob corresponding to the contact's image. By implementing this feature we will allow FB Contacts to be displayed correctly and we will remove significant code and complexity in the SMS app.
Reporter | ||
Updated•11 years ago
|
blocking-b2g: --- → leo?
Updated•11 years ago
|
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Comment 1•11 years ago
|
||
We need to take into account this change could affect SMS but also the email app, so better sync with the email folks to be sure we all are in the same page. Thanks guys! F.
Assignee | ||
Comment 2•11 years ago
|
||
(In reply to Jose M. Cantera from comment #0) > We need that the webcontact/tel activity returns detailed contact > information, currently only the tel number and the name are provided. We > need to provide, the contact names, the full tel field array (filtering out > the tels not seelcted). Finally, we need to experiment with the delay > experimented if we also transfer the blob corresponding to the contact's > image. Are you referring to modify the existing webcontacts/contact activity to provide more data, or to create a new webcontacts/tel activity?
Reporter | ||
Comment 3•11 years ago
|
||
(In reply to Fernando Campo (:fcampo) from comment #2) > (In reply to Jose M. Cantera from comment #0) > > We need that the webcontact/tel activity returns detailed contact > > information, currently only the tel number and the name are provided. We > > need to provide, the contact names, the full tel field array (filtering out > > the tels not seelcted). Finally, we need to experiment with the delay > > experimented if we also transfer the blob corresponding to the contact's > > image. > > Are you referring to modify the existing webcontacts/contact activity to > provide more data, or to create a new webcontacts/tel activity? I would start by creating a new webcontact/tel activity that provides contact info and the selected phone (as specified by comment #1) and then we can align the rest of activities with this new approach. By following this strategy we can avoid compatibility problems with other apps as Francisco warned. thanks
Comment 4•11 years ago
|
||
Triage - Seems to be non-trivial improvement, as we're tight on leo schedule and there is not direct user impact with this, renoming to koi.
blocking-b2g: leo? → koi?
Assignee | ||
Comment 5•11 years ago
|
||
Not a patch but a first proposal for the new activity, trying not to mess up too much the current architecture, open for discussion on the approach
Attachment #785828 -
Flags: feedback?(jmcf)
Attachment #785828 -
Flags: feedback?(fbsc)
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 785828 [details] [review] Link - https://github.com/mozilla-b2g/gaia/pull/11356 After the feedback given in github, and the update on the code, I'm moving this into an official PR for review. After talking with Borja, adding the new activity but not using it from any app (leaving that for a followup)
Attachment #785828 -
Flags: feedback?(jmcf) → review?(jmcf)
Comment 7•11 years ago
|
||
ni? Fernando for complexity in v1.2 timeframe
Flags: needinfo?(fernando.campo)
Whiteboard: [comms-triaged]
Assignee | ||
Comment 8•11 years ago
|
||
New version of the patch with tests should be ready today or monday tops. Complexity for adding it to 1.2 shouldn't be high, as the code just adds the possibility of using a new activity type, but doesn't call it from anywhere, so shouldn't break the running code at all. But it's needed for both contacts and sms, as comment 1 states. So I think that koi+ is reasonable enough.
Flags: needinfo?(fernando.campo)
Updated•11 years ago
|
blocking-b2g: koi? → koi+
Whiteboard: [comms-triaged] → [u=commsapps-user c=contacts p=0]
Assignee | ||
Comment 9•11 years ago
|
||
New version of the patch, with tests, and modifications on the code Adding reviewers as Jose Manuel is on holidays
Attachment #785828 -
Attachment is obsolete: true
Attachment #785828 -
Flags: review?(jmcf)
Attachment #785828 -
Flags: feedback?(fbsc)
Attachment #789538 -
Flags: review?(jmcf)
Attachment #789538 -
Flags: review?(francisco.jordano)
Comment 10•11 years ago
|
||
Just added some minor comments on github. Thanks Fernando!
Comment 11•11 years ago
|
||
Comment on attachment 789538 [details] [review] patch v2 - https://github.com/mozilla-b2g/gaia/pull/11507 Great work, thanks for adding unit tests to the activity handling in contacts :)
Attachment #789538 -
Flags: review?(francisco.jordano) → review+
Assignee | ||
Comment 12•11 years ago
|
||
Merged on master - e4bf40d42463846ee7331e4e1853106d1e23768f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment #789538 -
Flags: review?(jmcf)
Updated•11 years ago
|
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•