Closed
Bug 900487
Opened 11 years ago
Closed 11 years ago
IonMonkey: (ARM) bailoutIf still bails in parallel mode
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: mjrosenb, Unassigned)
Details
Attachments
(1 file)
|
1.49 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
Evidently bailing out is a big nono with paralleljs. We should not do that.
Attachment #784367 -
Flags: review?(shu)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 784367 [details] [diff] [review]
/home/mjrosenb/patches/parBailoutIf-r0.patch
Review of attachment 784367 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/arm/CodeGenerator-arm.cpp
@@ +184,5 @@
> + case SequentialExecution:
> + break;
> + default:
> + MOZ_ASSUME_UNREACHABLE("No such execution mode");
> + }
Nit: Maybe refactor this chunk? Not a big deal though; newline after the switch if no refactoring.
Attachment #784367 -
Flags: review?(shu) → review+
|
Reporter | |
Comment 2•11 years ago
|
||
Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/0c63bb80010c
I mis-interpreted the nit, and will land a follow-up whitespace-fixing patch.
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•