900500 - Add pref to bypass devtool's prompt on remote connection

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Alexandre Poirot [:ochameau]]

When using new remote debugging feature on a developer phone,
you quickly get tired to have to accept new incoming connection.
I suggest introducing a pref to allow bypassing this prompt on developer builds.

(In parralel, I'll tune gaia build system to set this pref on developer mode)

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Add pref to bypass devtool's prompt on remote connection

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 784387 [details] [diff] [review]
Add pref to bypass devtool's prompt on remote connection

Review of attachment 784387 [details] [diff] [review]:
-----------------------------------------------------------------

Code-wise the change looks fine, but I don't know if the security team will be happy to have a pref available that can disable that prompt. Mark and Rob would probably know better, or can find the right people to ask.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 784387 [details] [diff] [review]
Add pref to bypass devtool's prompt on remote connection

Review of attachment 784387 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with the change, but would like Mark's opinion on whether this is a good thing to do or not. For those who do a lot of debugging or automation, this will be a boon.

Comment 4

[Mark Goodwin [:mgoodwin]]

This does look super useful for a number of reasons; I'm fine with the pref if it's off by default.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

What I did for Thunderbird is to check for devtools.debugger.force-local. If only local connections are allowed, I'd say its ok to leave out the prompt. Maybe this makes sense instead here too?

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Oh, sorry. I had bug 900562 in mind when writing that comment. I see this is about real remote connections.

Comment 8

[Alexandre Poirot [:ochameau]]

(In reply to Mark Goodwin [:mgoodwin] from comment #4)
> This does look super useful for a number of reasons; I'm fine with the pref
> if it's off by default.

It is off by default unless you set developer mode in gaia build system.
Does that mean r+?

Comment 9

[Mark Goodwin [:mgoodwin]]

(In reply to Alexandre Poirot (:ochameau) from comment #8)
> (In reply to Mark Goodwin [:mgoodwin] from comment #4)
> > This does look super useful for a number of reasons; I'm fine with the pref
> > if it's off by default.
> 
> It is off by default unless you set developer mode in gaia build system.
> Does that mean r+?

I missed the FxOS context here.  I'm OK with this. I've spoken to Paul; he's OK with this too.

r+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/de25af81d74e

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/de25af81d74e