Closed Bug 900500 Opened 6 years ago Closed 6 years ago

Add pref to bypass devtool's prompt on remote connection

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

When using new remote debugging feature on a developer phone,
you quickly get tired to have to accept new incoming connection.
I suggest introducing a pref to allow bypassing this prompt on developer builds.

(In parralel, I'll tune gaia build system to set this pref on developer mode)
Blocks: 900509
Assignee: nobody → poirot.alex
Attachment #784387 - Flags: review?(past)
Comment on attachment 784387 [details] [diff] [review]
Add pref to bypass devtool's prompt on remote connection

Review of attachment 784387 [details] [diff] [review]:
-----------------------------------------------------------------

Code-wise the change looks fine, but I don't know if the security team will be happy to have a pref available that can disable that prompt. Mark and Rob would probably know better, or can find the right people to ask.
Attachment #784387 - Flags: review?(rcampbell)
Attachment #784387 - Flags: review?(past)
Attachment #784387 - Flags: review?(mgoodwin)
Comment on attachment 784387 [details] [diff] [review]
Add pref to bypass devtool's prompt on remote connection

Review of attachment 784387 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with the change, but would like Mark's opinion on whether this is a good thing to do or not. For those who do a lot of debugging or automation, this will be a boon.
Attachment #784387 - Flags: review?(rcampbell) → review+
This does look super useful for a number of reasons; I'm fine with the pref if it's off by default.
What I did for Thunderbird is to check for devtools.debugger.force-local. If only local connections are allowed, I'd say its ok to leave out the prompt. Maybe this makes sense instead here too?
Oh, sorry. I had bug 900562 in mind when writing that comment. I see this is about real remote connections.
Duplicate of this bug: 900562
(In reply to Mark Goodwin [:mgoodwin] from comment #4)
> This does look super useful for a number of reasons; I'm fine with the pref
> if it's off by default.

It is off by default unless you set developer mode in gaia build system.
Does that mean r+?
(In reply to Alexandre Poirot (:ochameau) from comment #8)
> (In reply to Mark Goodwin [:mgoodwin] from comment #4)
> > This does look super useful for a number of reasons; I'm fine with the pref
> > if it's off by default.
> 
> It is off by default unless you set developer mode in gaia build system.
> Does that mean r+?

I missed the FxOS context here.  I'm OK with this. I've spoken to Paul; he's OK with this too.

r+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/de25af81d74e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Attachment #784387 - Flags: review?(mgoodwin) → review+
Duplicate of this bug: 989234
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.