install gcc 4.7.3 for testing purposes

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: froydnj, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

I'm seeing some GCC 4.7-specific breakage on several try pushes:

https://tbpl.mozilla.org/?tree=Try&rev=6c805cfe771b

I'm not seeing the same breakage on my home Debian box (which runs a patched version of GCC 4.7.2).

Looking at the patches for the Debian package and the changes made between GCC 4.7.2 and 4.7.3, there've been a number of C++-specific fixes, including at least one fix that's in both Debian and GCC 4.7.3 that plausibly looks like it might fix the Fedora crashes in that Try push above.  Fixing the Android crash is another story; hopefully the GCC 4.7 upgrade on android going on elsewhere will fix that bug.

Therefore, I'd like to get 4.7.3 installed--at least for testing purposes--and if that fixes compiler crashes, then we can upgrade to that.  Might also address some of the intermittent Linux PGO failures we've been seeing?
Rail, glandium mentioned that you might be a good person to build and upload GCC 4.7.3 RPMs?
Flags: needinfo?(rail)
(Assignee)

Comment 2

4 years ago
Sure, I'll take care of it.
Assignee: nobody → rail
Flags: needinfo?(rail)
(Assignee)

Comment 3

4 years ago
Created attachment 784462 [details] [diff] [review]
[WIP] gcc 4.7.3 spec
(Assignee)

Comment 4

4 years ago
Created attachment 784478 [details] [diff] [review]
[WIP] gcc 4.7.3 spec

s/2010/2013
Attachment #784462 - Attachment is obsolete: true
(Assignee)

Comment 5

4 years ago
Nathan, we want these packages on try, correct?
Flags: needinfo?(nfroyd)
(In reply to Rail Aliiev [:rail] from comment #5)
> Nathan, we want these packages on try, correct?

Assuming you mean "we want to be able to push to try and select these packages with appropriate mozconfig tweaks", then yes.  Is that what you mean?
Flags: needinfo?(nfroyd) → needinfo?(rail)
(Assignee)

Comment 7

4 years ago
Yeah, exactly what I meant.
Flags: needinfo?(rail)
(Assignee)

Comment 8

4 years ago
Comment on attachment 784478 [details] [diff] [review]
[WIP] gcc 4.7.3 spec

Nathan, besides gcc, I bumped mpfr and gmp version. Do you feel comfortable with this change?
Attachment #784478 - Flags: review?(nfroyd)
Comment on attachment 784478 [details] [diff] [review]
[WIP] gcc 4.7.3 spec

Review of attachment 784478 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is fine.
Attachment #784478 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 10

4 years ago
Comment on attachment 784478 [details] [diff] [review]
[WIP] gcc 4.7.3 spec

https://hg.mozilla.org/build/rpm-sources/rev/73c170662308
Attachment #784478 - Flags: checked-in+
(Assignee)

Comment 11

4 years ago
Created attachment 784563 [details] [diff] [review]
gcc.diff

Install gcc 4.7.3 in parallel with 4.7.2.
Attachment #784563 - Flags: review?(hwine)
Comment on attachment 784563 [details] [diff] [review]
gcc.diff

Review of attachment 784563 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm -- per rail no request for change in thunderbird configs
Attachment #784563 - Flags: review?(hwine) → review+
(Assignee)

Comment 13

4 years ago
Comment on attachment 784563 [details] [diff] [review]
gcc.diff

https://hg.mozilla.org/build/buildbot-configs/rev/f8803a3c1c53

The package will be available after next reconfig (Tue). Let me know if you need it ASAP, so I reconfig earlier.
Attachment #784563 - Flags: checked-in+
(In reply to Rail Aliiev [:rail] from comment #13)
> The package will be available after next reconfig (Tue). Let me know if you
> need it ASAP, so I reconfig earlier.

Sounds good.  Thanks for the quick turnaround!
in production
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Created attachment 788852 [details] [diff] [review]
gcc additions for Thunderbird

The previous patch didn't add the gcc update for Thunderbird.
Attachment #788852 - Flags: review?(rail)
(Assignee)

Updated

4 years ago
Attachment #788852 - Flags: review?(rail) → review+
Comment on attachment 788852 [details] [diff] [review]
gcc additions for Thunderbird

https://hg.mozilla.org/build/buildbot-configs/rev/3f4f03cc48e6
Attachment #788852 - Flags: checked-in+
Product: mozilla.org → Release Engineering
In production.
You need to log in before you can comment on or make changes to this bug.