900577 - Consider making IDBKeyRange not inherit from nsISupports

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, enhancement, P5)

Comment 1

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 5

[Jan Varga [:janv]]

NS_DECL_CYCLE_COLLECTING_ISUPPORTS would probably need to be changed to NS_INLINE_DECL_CYCLE_COLLECTING_NATIVE_REFCOUNTING or something like that

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 900577 - Make IDBKeyRange not inherit from nsISupports; r=#dom-storage

Comment 7

[Jan Varga [:janv]]

Attachment: Bug 900577 - Remove mGlobal and GetParentObject from IDBKeyRange; r=#dom-storage

This is done based on the note in Web IDL bindings documentation:

If your object can only be reflected into JS by creating it, not by retrieving
it from somewhere, you can skip steps 1 and 2 above and instead add
'wrapperCache': False to your descriptor. You will need to flag the functions
that return your object as [NewObject] in the Web IDL. If your object is not
refcounted then the return value of functions that return it should return a
UniquePtr.

The step 1 is about inheriting from nsWrapperCache and step 2 is about ensuring
GetParentObject for the class.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3af2e5e4f512
Make IDBKeyRange not inherit from nsISupports; r=dom-storage-reviewers,peterv,asuth
https://hg.mozilla.org/integration/autoland/rev/acfeaa005834
Remove mGlobal and GetParentObject from IDBKeyRange; r=dom-storage-reviewers,asuth

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3af2e5e4f512
https://hg.mozilla.org/mozilla-central/rev/acfeaa005834