Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mjschranz, Assigned: mjschranz)

Tracking

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
There are a couple present preventing travis from passing. Let's fix em.
(Assignee)

Updated

6 years ago
Assignee: schranz.m → nobody
Assignee: nobody → scott
I didn't do the less linting in this patch, was more concerned with the js, and I was in there anyway.

There is actually quite a bit of less lint fails, not sure, maybe we should do them in another ticket? I'm willing to do it in this ticket, but, later...
Attachment #819406 - Flags: review?(schranz.m)
(Assignee)

Comment 2

6 years ago
This moves it to be included manually instead of apart of our own CSS, removing the lint errors.

Problem exists on export however. The arrow used in text events with links doesn't work.
Attachment #819474 - Flags: feedback?(scott)
(Assignee)

Comment 3

6 years ago
Good chance Jon would have insight as to why. It looks to me like our link/script tags ignore the <base> tag on export and try to load that CSS from amazon directly.
Flags: needinfo?(jon)
That link url doesn't exist for me on export anyway, even without this patch.
(Assignee)

Comment 6

6 years ago
Actually, no I was just having some weird errors. This patch ( with my changes merged ) brings the icon up for me on export too.

Yay!
Flags: needinfo?(jon)
(Assignee)

Comment 7

6 years ago
Comment on attachment 819406 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/277

We should merge in my patch to solve this once and for all.
Attachment #819406 - Flags: review?(schranz.m) → review-
Yeah, adding font-awesome is a good move
(Assignee)

Updated

6 years ago
Attachment #819406 - Flags: review?(schranz.m) → review+
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/f7303cdde3906709a0a944cc1eb063514a85c530
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 11

6 years ago
Going to reopen this now to finish the job with the CSS lint errors.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 12

6 years ago
Attachment #819474 - Attachment is obsolete: true
Attachment #819474 - Flags: feedback?(scott)
Attachment #821039 - Flags: review?(scott)
(Assignee)

Updated

6 years ago
Assignee: scott → schranz.m
Status: REOPENED → ASSIGNED
Attachment #821039 - Flags: review?(scott) → review+
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.