900615 - [traceback] DoesNotExist: AppFeatures matching query does not exist. - django.db.models.query in get

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

200 tracebacks: http://sentry.mktmon.services.phx1.mozilla.com/mkt/marketplacefirefoxcom/group/527/
978 tracebacks: http://sentry.mktmon.services.phx1.mozilla.com/mkt/marketplacefirefoxcom/group/470/

DoesNotExist: AppFeatures matching query does not exist.

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "newrelic/api/object_wrapper.py", line 216, in __call__
    self._nr_instance, args, kwargs)
  File "newrelic/hooks/framework_django.py", line 475, in wrapper
    return wrapped(*args, **kwargs)
  File "rest_framework/viewsets.py", line 78, in view
    return self.dispatch(request, *args, **kwargs)
  File "django/views/decorators/csrf.py", line 77, in wrapped_view
    return view_func(*args, **kwargs)
  File "rest_framework/views.py", line 326, in dispatch
    response = self.handle_exception(exc)
  File "rest_framework/views.py", line 323, in dispatch
    response = handler(request, *args, **kwargs)
  File "rest_framework/mixins.py", line 106, in retrieve
    return Response(serializer.data)
  File "rest_framework/serializers.py", line 501, in data
    self._data = self.to_native(obj)
  File "mkt/versions/api.py", line 31, in to_native
    'features': AppFeaturesSerializer().to_native(obj.features),
  File "django/db/models/fields/related.py", line 255, in __get__
    rel_obj = self.get_query_set(instance=instance).get(**params)
  File "django/db/models/query.py", line 366, in get
    % self.model._meta.object_name)

Comment 1

[Christopher Van Wiemeersch [:cvan]]

As Rob discovered, this is a version for a theme. We should be filtering by webapps.

Comment 2

[Mathieu Pillard [:mat]]

bug 913010 got rid of one of a similar issue happening sometimes in the reviewer tools, but this is more straightforward, we just should filter correctly in mkt/versions/api.py.

Comment 3

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/195bed2ccf1c0b456fcb3e5e85deb394c92376d4

STR:
- Load the following URLs:
- https://marketplace-dev.allizom.org/api/v1/apps/versions/1490471/ should return a 404 error (it's a version for a theme)
- https://marketplace-dev.allizom.org/api/v1/apps/versions/1490543/ should return a 200 with some info about the version (it's a version for an app)

Comment 4

[krupa raj[:krupa]]

16:03:09.404 GET https://marketplace-dev.allizom.org/api/v1/apps/versions/1490471/ [HTTP/1.1 404 NOT FOUND 138ms]

16:03:53.860 GET https://marketplace-dev.allizom.org/api/v1/apps/versions/1490543/ [HTTP/1.1 200 OK 77ms]

I also checked that it doesn't traceback for other add-on types:

themes: https://marketplace-dev.allizom.org/api/v1/apps/versions/213374/
search engines: https://marketplace-dev.allizom.org/api/v1/apps/versions/7098/
dictionaries: https://marketplace-dev.allizom.org/api/v1/apps/versions/354872/
complete theme: https://marketplace-dev.allizom.org/api/v1/apps/versions/4908/
extension: https://marketplace-dev.allizom.org/api/v1/apps/versions/1865/