Youtube embedded videos broken in templates

NEW
Unassigned

Status

support.mozilla.org
Knowledge Base Software
P4
normal
5 years ago
9 months ago

People

(Reporter: Noah, Unassigned)

Tracking

({regression})

unspecified
Future
regression

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=user c=wiki p=3 s=2013.backlog)

(Reporter)

Description

5 years ago
A recent Youtube iframe security bugfix broke embedded Youtube videos in templates.

The video from this template: 
https://support.mozilla.org/en-US/kb/templatewuws

Doesn't work in the article that uses that template: 
https://support.mozilla.org/en-US/kb/contributor-news-resources

In the KB article under "Meeting Video", it just shows the raw iframe code.

<iframe allowfullscreen="" frameborder="0" src="//www.youtube.com/embed/SdiU3bguhSM?wmode=transparent&amp;rel=0&amp;modestbranding=1"></iframe>

This was caused by Bug 898769.
This broke with the fix to bug 898769.

Some older related bugs:
bug 854554
bug 862120

The issue is that Templates converted into HTML and inserted into the article that includes them before the final HTML sanitization done by bleack.clean(). bleach.clean() kills any iframes that are in the HTML at that point.
Whiteboard: u=user c=wiki p= s=2013.15
Keywords: regression
Target Milestone: --- → 2013Q3
Putting in the next sprint for somebody to look at.
Whiteboard: u=user c=wiki p= s=2013.15 → u=user c=wiki p= s=2013.16
Making this a P1 because it's a regression. :verdi, are there a lot of articles that depend on this?

I don't know how many points this is going to take at this point. Assigning it 3 for now to make sure we block enough time in the sprint. We can adjust after some research.
Priority: -- → P1
Whiteboard: u=user c=wiki p= s=2013.16 → u=user c=wiki p=3 s=2013.16

Comment 4

5 years ago
This should not be a P1. The only place that I know for sure that this is used is on this contributor page - https://support.mozilla.org/en-US/kb/contributor-news-resources

I believe that all KB articles that have videos do not have the videos in a template. 

This feature being broken is an annoyance but I don't believe it impacts users at all.
Thanks Verdi! Good to know , whew!
Priority: P1 → P3
Pushing along to the next sprint given the lower priority and too much already in .16
Whiteboard: u=user c=wiki p=3 s=2013.16 → u=user c=wiki p=3 s=2013.17
moving to the backlog given the low priority
Whiteboard: u=user c=wiki p=3 s=2013.17 → u=user c=wiki p=3 s=2013.backlog
Let's try this again next sprint.
Whiteboard: u=user c=wiki p=3 s=2013.backlog → u=user c=wiki p=3 s=2013.18
This isn't going to be trivial to fix. I'd like to focus 2013.18 on Open Badges and Persona.
Whiteboard: u=user c=wiki p=3 s=2013.18 → u=user c=wiki p=3 s=2013.backlog
Q3 is over... => Q4
Target Milestone: 2013Q3 → 2013Q4
Moving 2013Q4 bugs to the Future since we didnt care enough about them in 2014Q1.
Target Milestone: 2013Q4 → Future
You need to log in before you can comment on or make changes to this bug.