900848 - [zffos1.1][dialer] Call log entry misses label for caller id withheld numbers

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[zhangwei]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:25.0) Gecko/20130728 Firefox/25.0 (Nightly/Aurora)
Build ID: 20130728030204

Steps to reproduce:

1、close caller ID display service.
2、have a call , reject or answer.
3、check call log


Actual results:

there is no incoming call log.


Expected results:

there is a incoming call log.

Comment 1

[Scoobidiver (away)]

leo+ requested per bug 899451.

Comment 2

[Preeti Raghunath(:Preeti)]

Please clearly state:
1) How the caller id service needs to be closed

Comment 3

[zhangwei]

so sorry!
This service is that the caller id is hidden in the incoming call interface when have a incoming call.In China, to close this service, we usually send a command to mobile operators.

Comment 4

[:gerard-majax]

(In reply to zhangwei from comment #3)
> so sorry!
> This service is that the caller id is hidden in the incoming call interface
> when have a incoming call.In China, to close this service, we usually send a
> command to mobile operators.

I think your STR are not enough. Could you be much more precise ?

I tested calling from an Android phone, with caller id set to hidden, and I get an entry in the call log on v1-train.

Could you please provide also references to your build ?

Comment 5

[zhangwei]

the STR are enough, because when i reopen the function of show caller id and miss an incoming call, there is a call log.

my build

gaia version:
commit 45f6a739b09292e16717fb21003386c914ca29c2
Author: Vivien Nicolas <[e-mail]>
Date:   Fri Aug 2 21:40:04 2013 +0200
    Bug 901044 - Everything.me needs additional strings for the search bar. r=pi


gecko version:

commit 70e86369a5c5068a8c4934b4af2fca65d70340de
Author: Justin Lebar <[e-mail]>
Date:   Tue Aug 6 13:19:26 2013 -0700

    Bug 899354 - Only ever add one visibilitychange listener to BrowserElementPa

    This prevents a leak when we run tests that create thousands of BrowserEleme

Comment 6

[:gerard-majax]

Thanks for those. Do we agree on what you mean about Caller ID ? In my mind, it's the ability to show/hide your phone number when placing a call. As far as I can tell, this Caller ID support in Gaia settings is not for v1-train but for master. Hence, I still cannot understand correctly your STR.

Plus, can you describe what you mean by « there is a call log » ?

If it can help, do not hesitate to provide screenshots !

Comment 7

[zhangwei]

Attachment: call log on android marked with a red

on android , there is an incoming call, the caller id is hidden. After the call hang up or not be answered, there is still a call log as scrren shot. but on firefox os ,it does not produce a call log.

Comment 8

[:gerard-majax]

(In reply to zhangwei from comment #7)
> Created attachment 787384 [details]
> call log on android marked with a red
> 
> on android , there is an incoming call, the caller id is hidden. After the
> call hang up or not be answered, there is still a call log as scrren shot.
> but on firefox os ,it does not produce a call log.

You deleted the attachement, I can't view it :(

Comment 9

[zhangwei]

Attachment: call log on android.bmp

Comment 10

[:gerard-majax]

(In reply to zhangwei from comment #9)
> Created attachment 787386 [details]
> call log on android.bmp

This one is also marked as deleted ! :(

Comment 11

[zhangwei]

Attachment: call log on android.JPG

Comment 12

[zhangwei]

sorry , it can not work in IE browser!

Comment 13

[:gerard-majax]

(In reply to zhangwei from comment #12)
> sorry , it can not work in IE browser!

Okay, I could see the latest attachment and Taipei colleagues helped me in reading the call log. So now, I think I understand the issue, please correct me if I'm wrong:

On Android, when we receive a call from a masked caller id, the call log displays an entry with the « Unknown » label (as in attachment #787389 [details]).

Currently, what you report is that your Firefox OS build does not have this behavior. Does it means :
 - There is no call log entry at all for the masked caller id call placed ?
 - There is a call log entry but there is no label for it ?

I think I had the latest behavior yesterday when trying, and according to Anthony that would be a regression. Please confirm me that this is what you meant :).

Comment 14

[zhangwei]

There is no call log entry at all for the masked caller id call placed.

Comment 15

[:gerard-majax]

(In reply to zhangwei from comment #14)
> There is no call log entry at all for the masked caller id call placed.

I can't reproduce this then. Could you re-test with an uptodate v1-train build please ?

Comment 16

[:gerard-majax]

And by the way, could you provide complete |adb logcat| from boot to shudown when you reproduce this on b2g ?

Comment 17

[:gerard-majax]

Okay, we tested with Anthony against 1.0.1 and the call log displays "Unknown number", so either way there is a regression here.

Comment 18

[:gerard-majax]

Reproduced on master, too.

Comment 19

[:gerard-majax]

It would seem that the "unkwown" string has disappeared from the locales ?

Comment 20

[:gerard-majax]

This is a regression from 5ba3e5573f5be184d7c82836369d5915217baba6 of bug 852515 : the string identifier "unknown" has been changed to "withheld-number" but the call log was missed.

Comment 21

[zhangwei]

(In reply to Alexandre LISSY :gerard-majax from comment #15)
> (In reply to zhangwei from comment #14)
> > There is no call log entry at all for the masked caller id call placed.
> 
> I can't reproduce this then. Could you re-test with an uptodate v1-train
> build please ?

i m not sure that "the masked caller id ",is it the same that i said,

so i comment it clearly.

what i mean is that a service "来电显示" that i translate as "caller id service" which the Operator close it, then UE(User Equipment) can't get the phone number from every incoming call.not blacklist or whitelist.

And this bug is still in the latest v1_train.

Are we clear?

Comment 22

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/gaia/pull/11421

Please find a link to the github pull request https://github.com/mozilla-b2g/gaia/pull/11421 that addresses this issue.

Comment 23

[:gerard-majax]

There is another usage of 'unknown' string in this file, I wonder if it's not a legit one ...

Comment 24

[Etienne Segonzac (:etienne)]

Comment on attachment 787407 [details]
Link to Github https://github.com/mozilla-b2g/gaia/pull/11421

Got it the first time :) Thanks!

Comment 25

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/2830c85f5fa44ac2f08578f81d8dbf47af09fa8e

Comment 26

[zhangwei]

(In reply to Etienne Segonzac (:etienne) from comment #25)
> https://github.com/mozilla-b2g/gaia/commit/
> 2830c85f5fa44ac2f08578f81d8dbf47af09fa8e

I've merged the code as the above-mentioned, but there is still not a call log entry in the call log application when miss a call. I don't known if i comment it clearly.what i mean is that a service "来电显示" that i translate as "caller id service" which the Operator close it, then UE(User Equipment) can't get the phone number from every incoming call.not blacklist or whitelist.

Comment 27

[:gerard-majax]

(In reply to zhangwei from comment #21)
> (In reply to Alexandre LISSY :gerard-majax from comment #15)
> > (In reply to zhangwei from comment #14)
> > > There is no call log entry at all for the masked caller id call placed.
> > 
> > I can't reproduce this then. Could you re-test with an uptodate v1-train
> > build please ?
> 
> i m not sure that "the masked caller id ",is it the same that i said,
> 
> so i comment it clearly.
> 
> what i mean is that a service "来电显示" that i translate as "caller id service"
> which the Operator close it, then UE(User Equipment) can't get the phone
> number from every incoming call.not blacklist or whitelist.
> 
> And this bug is still in the latest v1_train.
> 
> Are we clear?

Okay, so this is totally different from your first report then. Anyway this helped us fix another bug. I'll open a new one dedicated to your original issue.

Comment 28

[Ivan Tsay (:ITsay)]

Alexandre, while opening the new bug for the original issue, please add the dependency to this one, put [zffos1.1] on the summary title, and add [e-mail] in the cc list of the new bug for better tracking. Thank you!

Ivan

Comment 29

[:gerard-majax]

Done !

Comment 30

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 2830c85f5fa44ac2f08578f81d8dbf47af09fa8e to:
v1-train: e4895d542f5c48f835f41138dedd38397215544d

Comment 31

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: e4895d542f5c48f835f41138dedd38397215544d

Comment 32

[sbogati]

 This issue does not reproduce on the Leo MOZ RIL build. 
The "Withhold Number" entry is shown in the call log, after the call was placed from the Withhold number. 
 However, this issue still reproduces on today's Leo COM RIL build 
After receiving a call from the withhold number, the entry with the withhold number is not shown in the call log.
Build ID: 20130816041203
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/09a8c5b6b287
Gaia: 6040508a535b587d4155356a47b22d7bd9ea4de7
Platform Version: 18.1

 Should I file another bug for this issue or this bug can be reopened?

Comment 33

[:gerard-majax]

(In reply to sbogati from comment #32)
>  This issue does not reproduce on the Leo MOZ RIL build. 
> The "Withhold Number" entry is shown in the call log, after the call was
> placed from the Withhold number. 
>  However, this issue still reproduces on today's Leo COM RIL build 
> After receiving a call from the withhold number, the entry with the withhold
> number is not shown in the call log.
> Build ID: 20130816041203
> Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/09a8c5b6b287
> Gaia: 6040508a535b587d4155356a47b22d7bd9ea4de7
> Platform Version: 18.1
> 
>  Should I file another bug for this issue or this bug can be reopened?

This is being tracked in bug 903275

Comment 34

[Mila Davydova]

Changing the status-b2g18 tracking flag to Verified, as per comments 32 and 33, since the issue does not reproduce on the Leo MOZ RIL and, the COM RIL issue is being tracked in bug 903275