Closed Bug 900881 Opened 6 years ago Closed 6 years ago

Make localAccountUtils.js into a testing module

Categories

(MailNews Core :: Testing Infrastructure, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 25.0

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(4 files)

Part of the work for bug 896738 - move localAccountUtils.js to be a testing module, as that will fix a bunch of issues for us.
As it turns out, this is enough to get rid of all the localAccountUtils warnings. However, we'll go further and just get this cleaned up once and for all.
Attachment #784880 - Flags: review?(Pidgeot18)
This moves four of the five globals (i.e. all apart from the most used one).
Attachment #784898 - Flags: review?(Pidgeot18)
Some 258 instances replaced.
Attachment #784937 - Flags: review?(Pidgeot18)
This completes the change. There's something strange going on with making it a module, that some of the hidden/implicit QIs that happened before no longer work, so there's a bunch of tidy up to fix (and simplify!) those cases.

After this, I still get the same amount of tests failing as I did at the start, so hopefully I've got everything :-)
Attachment #784959 - Flags: review?(Pidgeot18)
Attachment #784880 - Flags: review?(Pidgeot18) → review+
Comment on attachment 784898 [details] [diff] [review]
Part 2 - move four of the five globals

Review of attachment 784898 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming that tests pass.
Attachment #784898 - Flags: review?(Pidgeot18) → review+
Comment on attachment 784959 [details] [diff] [review]
Part 4 - make it a testing module

Review of attachment 784959 [details] [diff] [review]:
-----------------------------------------------------------------

Yay, one step closer to killing gDEPTH!
Attachment #784959 - Flags: review?(Pidgeot18) → review+
Comment on attachment 784937 [details] [diff] [review]
Part 3 - move the last global

Review of attachment 784937 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/test/unit/test_bug428427.js
@@ +86,3 @@
>  
>    // search will look for tag tag1 in the inbox folder
> +  var searchTerm = makeSearchTerm(localAccountUtils.inboxFolder, tag1, 

Trailing whitespace while you're here.
Attachment #784937 - Flags: review?(Pidgeot18) → review+
You need to log in before you can comment on or make changes to this bug.