Closed Bug 900886 Opened 7 years ago Closed 7 years ago

Make the annotated summary generation log output more concise

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Current log output is often of the form:
{
Prefetching: Rev5 MacOSX Mountain Lion 10.8 try debug test mochitest-1 on 70c80dfde9f8
php /data/genericrhel6-dev/src/tbpl-dev.allizom.org/tbpl/dataimport/../php/getLogExcerpt.php id=25653506&type=annotated
Starting general_error log generation
Starting raw log generation
Generating raw log: 1366ms
Generating general_error log: 9428ms
Starting annotatedsummary log generation
  Bugs returned: 0
  Bugs returned: 0
* Search term: "TypeError: form is null"
  Found in cache
  Bugs returned: 0
* Search term: "TypeError: form is null"
  Found in cache
  Bugs returned: 0
* Search term: "TypeError: form is null"
  Found in cache
  Bugs returned: 0
* Search term: "TypeError: form is null"
  Found in cache
  Bugs returned: 0
* Search term: "TypeError: form is null"
  Found in cache
  Bugs returned: 0
* Search term: "TypeError: form is null"
  Found in cache
  Bugs returned: 0
* Search term: "TypeError: form is null"
  Found in cache
  Bugs returned: 0
* Search term: "TypeError: form is null"
  Found in cache
  Bugs returned: 0
* Search term: "test_decoder_disable.html"
  BzAPI query: 406ms
  Bugs returned: 0
* Search term: "test_fragment_noplay.html"
  BzAPI query: 363ms
  Bugs returned: 1
}

The loose "Bugs returned: 0" lines are annoying - and are when we've rejected a search term since it hit the blacklist. It also seems a bit unnecessary to state when we found no bugs - we should just report when we have. Similarly, there's no point saying found in cache - the abscence of the bzapi query line indicates that.

After the patch the above looks like:
{
Prefetching: Rev5 MacOSX Mountain Lion 10.8 try debug test mochitest-1 on 70c80dfde9f8
php /data/genericrhel6-dev/src/tbpl-dev.allizom.org/tbpl/dataimport/../php/getLogExcerpt.php id=25653506&type=annotated
Starting general_error log generation
Starting raw log generation
Generating raw log: 1366ms
Generating general_error log: 9428ms
Starting annotatedsummary log generation
* Search term: "TypeError: form is null"
* Search term: "TypeError: form is null"
* Search term: "TypeError: form is null"
* Search term: "TypeError: form is null"
* Search term: "TypeError: form is null"
* Search term: "TypeError: form is null"
* Search term: "TypeError: form is null"
* Search term: "TypeError: form is null"
* Search term: "test_decoder_disable.html"
  BzAPI query: 406ms
* Search term: "test_fragment_noplay.html"
  BzAPI query: 363ms
  Bugs returned: 1
}
Attached patch Patch v1Splinter Review
Blocks: 882670
Depends on: 900951
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Version: 5.0 → unspecified
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.