Closed Bug 900898 Opened 6 years ago Closed 6 years ago

Support TypedArray members in dictionaries and sequences of TypedArray

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(4 files, 1 obsolete file)

This is a spinoff from bug 868799 because I think we can do it right now.
Er, except for the no-arg-constructor problem (bug 868799 comment 8).  Gah!

Maybe I should give up and just add a way to construct these things with not args and an Init() method.  :(
Whiteboard: [need review]
Attachment #785337 - Attachment is obsolete: true
Attachment #785337 - Flags: review?(bugs)
Comment on attachment 785386 [details] [diff] [review]
Part 2 with silly bug fixed

Review of attachment 785386 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContext.h
@@ +751,5 @@
>                          WebGLfloat x2);
>      void VertexAttrib4f(WebGLuint index, WebGLfloat x0, WebGLfloat x1,
>                          WebGLfloat x2, WebGLfloat x3);
>  
> +    void VertexAttrib1fv(WebGLuint idx, const dom::Float32Array &arr) {

& to the left
https://tbpl.mozilla.org/?tree=Try&rev=adef504619a0

> & to the left

That's not the local style in the WebGL code.
Attachment #785336 - Flags: review?(bugs) → review+
Attachment #785386 - Flags: review?(bugs) → review+
Comment on attachment 785338 [details] [diff] [review]
part 3.  Support typed arrays inside dictionaries.

Hopefully I didn't miss anything important :)
Attachment #785338 - Flags: review?(bugs) → review+
Comment on attachment 785339 [details] [diff] [review]
part 4.  Support typed arrays inside sequences and variadics.

I wouldn't have
for ( ; ...,
but
for (; ...
Attachment #785339 - Flags: review?(bugs) → review+
Target Milestone: --- → mozilla26
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.