Changing mozSettings value of "keyboard.ftu.enabled" has no effect when launching the Keyboard app for the first time

VERIFIED FIXED

Status

Firefox OS
Gaia::Keyboard
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Bebe, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
STR:

1. Flash the phone with the latest master:
  Gecko  http://hg.mozilla.org/mozilla-central/rev/05d3797276d3
  Gaia  7eea78d212799ebbde7f4b78a05973b397c0b6d4
  BuildID 20130801101656
  Version 25.0a1
2. Change the mozSettings value of "keyboard.ftu.enabled" to false
  In Gaia UI Tests we use: 
     https://github.com/mozilla/gaia-ui-tests/blob/master/gaiatest/atoms/gaia_data_layer.js#L181

3. Try to edit a test field using the app



Expected:
3. The filed is editable and there is no FTU popup 


Actual:
3. The FTU popup is present and we have to dismiss it


This mozSettings property was requested in:

https://bugzilla.mozilla.org/show_bug.cgi?id=805586
Created attachment 784942 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11313

Pointer to Github pull-request
Comment on attachment 784942 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11313

Hi Jan,

Could you please review this simple patch that makes keyboard app listen to the change of "keyboard.ftu.enabled", which might be modified by Gaia UI test to disable the FTU screen of keyboard swipe down.

Thank you.
Attachment #784942 - Flags: review?(janjongboom)
Comment on attachment 784942 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11313

* Checked out branch
* make clean & make reset-gaia
* Go into UI test app -> Keyboard
* Click field
* FTU still shows up

Does something have to land in UI tests or?
Attachment #784942 - Flags: review?(janjongboom) → review-

Comment 4

5 years ago
Jan, we have already landed into UI tests:
https://github.com/mozilla/gaia-ui-tests/commit/ac2027d3a32199ce52ef463be160ebc1d1d051dd

Our tests will start passing when this patch is landed.
Zac, is this the same UI tests as the UI tests app on the phone? Or something else? Have you verified that this patch fixes the tests?

Comment 6

5 years ago
Jan, this is unrelated to the UI tests app.
The commit above does not verify that the patch fixes the tests. 

I think there is a misunderstanding about "UI tests" :) This bug is about our UI test automation suite, not the UI Tests app!
(Reporter)

Comment 7

5 years ago
I tested the patch and once it will lad it will fix our UI tests:
https://github.com/mozilla/gaia-ui-tests/blob/master/gaiatest/tests/keyboard/test_keyboard.py
Comment on attachment 784942 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11313

Alright, in that case I'll r+ it :-)
Attachment #784942 - Flags: review- → review+
Jan,

Sorry that make you confused that did not provide the exact way to verify this patch.

I have a 2nd commit in this branch,
https://github.com/RudyLu/gaia/tree/keyboard/Bug900905-listen_to_settingsChange_testing

So that you could:
 1. make clean and reset-gaia
 2. Go into Settings app -> Keyboard -> uncheck "Show keyboard FTU"
 3. Click an input field to trigger the keyboard

Please note that this additional commit is for testing only and won't land to master.

Thank you.
Verified that this works (Y).
Gaia master,
https://github.com/mozilla-b2g/gaia/commit/e112e1d05f5f2f155d2d9303fe96bd5cad7d22e2


Hi all,

Thanks for the verification and the review.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 12

5 years ago
Hi Rudy, this is in today's Nightly build but I can't see it working. We're still getting the keyboard FTU popping up.

Gecko  http://hg.mozilla.org/mozilla-central/rev/ad0ae007aa9e
Gaia  0ca0dba246d1372eb815772c8108395ab0abd0a4
BuildID 20130805070203
Version 25.0a1

Can you check it's all OK?

Comment 13

5 years ago
Rudy, I can confirm this is now good in the current build. It must have just missed the build noted in comment #12. 

Thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.