Closed Bug 900907 Opened 6 years ago Closed 6 years ago

[Keyboard] Update the pinyin IME layout with the UX specification

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

RESOLVED FIXED
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: lchang, Assigned: lchang)

References

Details

(Whiteboard: [ucid:SystemPlatform17, FT:System-Platform, koi:p2], [Sprint:2])

Attachments

(2 files)

No description provided.
Add keyword in whiteboard for tracking in https://wiki.mozilla.org/FirefoxOS/SprintStatus#Systems-Platform
blocking-b2g: --- → koi?
Priority: -- → P1
Whiteboard: [ucid:SystemPlatform17], [FT: System Platform], [Sprint: 2]
Blocks: 902361
Assignee: nobody → lchang
We don't use 〰「」in simplified chinese, we use 《》to block book names instead.
(In reply to Pin Zhang [:pzhang] from comment #3)
> We don't use 〰「」in simplified chinese, we use 《》to block book names instead.

I didn't find '=' in the spec, it's definitely a frequently used character, for example, people usually type double == for shortcut of "等等" which means "wait for a mimute".
Attached file Pull Request
This patch also implemented following features:

- optimize candidates rendering performance
- add candidate panel paging mechanism
- drop Traditional Chinese support

As Pin mentioned, the current layout of symbol panels do not fit the Simplified Chinese user's requirement. We will file a new bug to discuss how can we improve that.
Attachment #793903 - Flags: review?(rlu)
cc Jing Zhang.
Please refer to Bug 908592 to discuss the following enhancement about symbol panels.
How is the bug going on? 

It is blocking Bug 905530. Could this bug be landed before we enhance the symbol panels(Bug 908592)?
Status: NEW → ASSIGNED
Whiteboard: [ucid:SystemPlatform17], [FT: System Platform], [Sprint: 2] → [ucid:SystemPlatform17, FT: System Platform, koi:p2], [Sprint: 2]
Whiteboard: [ucid:SystemPlatform17, FT: System Platform, koi:p2], [Sprint: 2] → [ucid:SystemPlatform17, FT:System-Platform, koi:p2], [Sprint: 2]
Blocks: 906617
Flags: needinfo?(rlu)
I am reviewing Luke's patch, and should be able to finish this today.
Sorry for the delay.
Flags: needinfo?(rlu)
Whiteboard: [ucid:SystemPlatform17, FT:System-Platform, koi:p2], [Sprint: 2] → [ucid:SystemPlatform17, FT:System-Platform, koi:p2], [Sprint:2]
Comment on attachment 793903 [details]
Pull Request

Hi Luke,

I have reviewed this patch and it is good to merge with,
 1. Please help address the nits that I commented on the pull request.
 2. You have to resolve the conflict because now the new IME framework has landed to Gaia master.

Please set the review flag back so that I will get notified.

Thanks for this great work.
Attachment #793903 - Flags: review?(rlu) → feedback+
Hi Xulei,

I've reviewed the keyboard app part.
I also took a look at the changes made to apps/keyboard/js/imes/jspinyin/jspinyin.js, but are not confident that I am qualified to review that part, so could you please have a 2nd-round review this file?

Thanks.
Flags: needinfo?(xyuan)
Hi Rudy & Luke,

I've finished review. The quality of patch is good. I leave a few comments in the pull request.
Flags: needinfo?(xyuan) → needinfo?(lchang)
Depends on: 911903
Blocks: 900906
Hi Rudy and Xulei,

I've updated my patch and resolved the conflict.
Thanks very much for all your useful comments.
Flags: needinfo?(lchang)
Attachment #793903 - Flags: feedback+ → review?(rlu)
Comment on attachment 793903 [details]
Pull Request

r+ with some nits addressed.
Nice work, Luke.

Please help open a bug for some minor UX tweak,
 1. Adjust the padding (gray) at the top and bottom of the candidate panel.
 2. Do we need 1.5x graphics for the assets you added in this change?

Thanks.
Attachment #793903 - Flags: review?(rlu) → review+
Blocks: 913390
Blocks: 913397
Hi Rudy,

I've filed two bugs you mentioned as follow:
1. Bug 913390 
2. Bug 913397

Thanks for your review.
Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/67988ff5e5160ab7289de0072b1c7ccf441b06e5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+
You need to log in before you can comment on or make changes to this bug.