900907 - [Keyboard] Update the pinyin IME layout with the UX specification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

Comment 1

[Ivan Tsay (:ITsay)]

Add keyword in whiteboard for tracking in https://wiki.mozilla.org/FirefoxOS/SprintStatus#Systems-Platform

Comment 2

[Luke Chang [:lchang] (inactive)]

Attachment: IME - Pinyin layout specification (0726)

Comment 3

[Pin Zhang [:pzhang] (inactive)]

We don't use 〰「」in simplified chinese, we use 《》to block book names instead.

Comment 4

[Pin Zhang [:pzhang] (inactive)]

(In reply to Pin Zhang [:pzhang] from comment #3)
> We don't use 〰「」in simplified chinese, we use 《》to block book names instead.

I didn't find '=' in the spec, it's definitely a frequently used character, for example, people usually type double == for shortcut of "等等" which means "wait for a mimute".

Comment 5

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request

This patch also implemented following features:

- optimize candidates rendering performance
- add candidate panel paging mechanism
- drop Traditional Chinese support

As Pin mentioned, the current layout of symbol panels do not fit the Simplified Chinese user's requirement. We will file a new bug to discuss how can we improve that.

Comment 6

[Yuan Xulei [:yxl] (Leave from May 18)]

cc Jing Zhang.

Comment 7

[Luke Chang [:lchang] (inactive)]

Please refer to Bug 908592 to discuss the following enhancement about symbol panels.

Comment 8

[Yuan Xulei [:yxl] (Leave from May 18)]

How is the bug going on? 

It is blocking Bug 905530. Could this bug be landed before we enhance the symbol panels(Bug 908592)?

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I am reviewing Luke's patch, and should be able to finish this today.
Sorry for the delay.

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 793903 [details]
Pull Request

Hi Luke,

I have reviewed this patch and it is good to merge with,
 1. Please help address the nits that I commented on the pull request.
 2. You have to resolve the conflict because now the new IME framework has landed to Gaia master.

Please set the review flag back so that I will get notified.

Thanks for this great work.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Xulei,

I've reviewed the keyboard app part.
I also took a look at the changes made to apps/keyboard/js/imes/jspinyin/jspinyin.js, but are not confident that I am qualified to review that part, so could you please have a 2nd-round review this file?

Thanks.

Comment 12

[Yuan Xulei [:yxl] (Leave from May 18)]

Hi Rudy & Luke,

I've finished review. The quality of patch is good. I leave a few comments in the pull request.

Comment 13

[Luke Chang [:lchang] (inactive)]

Hi Rudy and Xulei,

I've updated my patch and resolved the conflict.
Thanks very much for all your useful comments.

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 793903 [details]
Pull Request

r+ with some nits addressed.
Nice work, Luke.

Please help open a bug for some minor UX tweak,
 1. Adjust the padding (gray) at the top and bottom of the candidate panel.
 2. Do we need 1.5x graphics for the assets you added in this change?

Thanks.

Comment 15

[Luke Chang [:lchang] (inactive)]

Hi Rudy,

I've filed two bugs you mentioned as follow:
1. Bug 913390 
2. Bug 913397

Thanks for your review.

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/67988ff5e5160ab7289de0072b1c7ccf441b06e5