Closed
Bug 900908
Opened 11 years ago
Closed 10 years ago
Use varadic macros in nsIClassInfoImpl.h and nsISupportsImpl.h
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: glandium, Assigned: poiru)
References
Details
Attachments
(4 files, 2 obsolete files)
48.65 KB,
patch
|
froydnj
:
review+
poiru
:
checkin+
|
Details | Diff | Splinter Review |
29.18 KB,
patch
|
froydnj
:
review+
poiru
:
checkin+
|
Details | Diff | Splinter Review |
541.92 KB,
patch
|
poiru
:
review+
RyanVM
:
checkin+
|
Details | Diff | Splinter Review |
17.15 KB,
patch
|
poiru
:
review+
RyanVM
:
checkin+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•11 years ago
|
Version: 24 Branch → Trunk
Assignee | ||
Comment 2•10 years ago
|
||
Assigning myself. I have patches for this that work fine on all our compilers (see https://tbpl.mozilla.org/?tree=Try&rev=fbf2c396891f), but I'll wait for bug 989460 to land before attaching them here.
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8411997 -
Flags: review?(nfroyd)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8411998 -
Flags: review?(nfroyd)
Comment 5•10 years ago
|
||
Comment on attachment 8411997 [details] [diff] [review] Part 1: Add variadic variants of numbered macros in nsISupportsImpl.h Review of attachment 8411997 [details] [diff] [review]: ----------------------------------------------------------------- This is excellent. ::: xpcom/glue/nsISupportsImpl.h @@ +826,5 @@ > NS_INTERFACE_TABLE_ENTRY(_class, nsISupports) \ > NS_INTERFACE_TABLE_END > > +#define NS_INTERFACE_TABLE(aClass, ...) \ > + MOZ_STATIC_ASSERT_VALID_ARG_COUNT(__VA_ARGS__); \ This correctly complains about the zero-argument case, yes? After reading bug 989460, it looks like it does, but there's enough macrology in there that I'd like to double-check.
Attachment #8411997 -
Flags: review?(nfroyd) → review+
Updated•10 years ago
|
Attachment #8411998 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Nathan Froyd (:froydnj) from comment #5) > This correctly complains about the zero-argument case, yes? Yep.
Assignee | ||
Comment 7•10 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=629e2f114268
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b6b08c9a5a0 https://hg.mozilla.org/integration/mozilla-inbound/rev/e4f8969d1142
Keywords: checkin-needed
Comment 9•10 years ago
|
||
(Still slightly confusing that you need to use NS_IMPL_ISUPPORTS_INHERITED0)
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3b6b08c9a5a0 https://hg.mozilla.org/mozilla-central/rev/e4f8969d1142
Assignee | ||
Comment 11•10 years ago
|
||
Attachment #8412865 -
Flags: review?(nfroyd)
Assignee | ||
Comment 12•10 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=0717302deed9
Attachment #8412866 -
Flags: review?(nfroyd)
Comment 13•10 years ago
|
||
Comment on attachment 8412865 [details] [diff] [review] Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants Review of attachment 8412865 [details] [diff] [review]: ----------------------------------------------------------------- r/rs=me. You can imagine that I didn't examine all of these individually. :)
Attachment #8412865 -
Flags: review?(nfroyd) → review+
Updated•10 years ago
|
Attachment #8412866 -
Flags: review?(nfroyd) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8411997 -
Flags: checkin+
Assignee | ||
Updated•10 years ago
|
Attachment #8411998 -
Flags: checkin+
Assignee | ||
Comment 14•10 years ago
|
||
Rebased.
Attachment #8412865 -
Attachment is obsolete: true
Attachment #8413344 -
Flags: review+
Assignee | ||
Comment 15•10 years ago
|
||
Attachment #8412866 -
Attachment is obsolete: true
Attachment #8413345 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Whiteboard: [leave open]
Updated•10 years ago
|
Attachment #8413344 -
Flags: checkin+
Updated•10 years ago
|
Attachment #8413345 -
Flags: checkin+
Comment 16•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c1c7e45c902 https://hg.mozilla.org/integration/mozilla-inbound/rev/bb248db2c54c
Keywords: checkin-needed
Comment 17•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6c1c7e45c902 https://hg.mozilla.org/mozilla-central/rev/bb248db2c54c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Comment 18•10 years ago
|
||
I would appreciate it, if, in the future, these kinds of mass changes were announced on newsgroups before they occurred.
Assignee | ||
Comment 19•10 years ago
|
||
(In reply to Joshua Cranmer [:jcranmer] from comment #18) > I would appreciate it, if, in the future, these kinds of mass changes were > announced on newsgroups before they occurred. Sorry! I made a post now: https://groups.google.com/d/msg/mozilla.dev.platform/AXtW93QU6d8/91F-wdCvhq4J
You need to log in
before you can comment on or make changes to this bug.
Description
•