900925 - [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: chrome://browser/content/aboutDialog.js :: init :: line 14" data: no]

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/05d3797276d3
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130801 Firefox/25.0 ID:20130801030223


Steps To Reproduce:
1. Alt > Tools > About Nightly

Actual Results:
An error shous in Browser Console
--
[Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://browser/content/aboutDialog.js :: init :: line 14"  data: no] @ chrome://browser/content/aboutDialog.js:32

Expected Results:
No error.



Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/6b41552ecce1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130719 Firefox/25.0 ID:20130719131550
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/1273e2556a0f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130719 Firefox/25.0 ID:20130719131750
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6b41552ecce1&tochange=1273e2556a0f


Regressed by:
1273e2556a0f	Robert Strong — Wallpaper fix - Bug 895473 - [Mac and Linux] Custom distribution settings for yahoo de and es distributions are not being set. r=mconnor

Comment 1

[Robert Strong (they/them - no direct email)]

mconnor, this is caused by adding the report error as you requested in bug 895473 comment #4

Comment 2

[Robert Strong (they/them - no direct email)]

Mike, given comment #1 what do you want to do with this?

Comment 3

[Mike Connor [:mconnor]]

In theory I'm on PTO, won't be around to see replies.

This is just reporting the error that's getting caught, I assume, so it's not impeding functionality, so other than perhaps fixing the underlying cause I see little cause for concern.

Previously this would have meant bustage, now we're just catching and reporting the error, thus I do not believe this should block anything.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Mike, I removed the reportError that was added so it is the same as it was previously and added a new try catch so only the actual issue will be reported.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 8334378 [details] [diff] [review]
patch rev1

Looks good.  With the try/catch, the comment feels slightly untrue, but meh. [1]

[1] https://twitter.com/iamdevloper/status/397664295875805184

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch as pushed with updated comment

Comment 7

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/74872a1388ef

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/74872a1388ef

Comment 9

[Andrei Vaida [:avaida]]

User Agents:
[1] Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Firefox/24.0
[2] Mozilla/5.0 (Windows NT 6.2; rv:24.0) Gecko/20100101 Firefox/24.0
[3] Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Firefox/24.0
[4] Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Firefox/24.0

This issue is also reproducible on Fx ESR 24.3.0 (Build ID: 20140128141233) using:
- Windows 7 64-bit [1]
- Windows 8 32-bit [2]
- Ubuntu 12.04 32-bit [3]
- Mac OS X 10.7 [4]

Comment 10

[Ioana (away)]

Verified as fixed with Firefox 28.0b3 on Mac OS X 10.7.5, Windows 7 64bit and Ubuntu 12.10 64bit.

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

This doesn't meet ESR criteria, nor is it something that the ESR community has asked to see fixed due to widespread impact, minus & wontfixing for esr branch.