900970 - shutdown.stamp should be created before mozpool is invoked

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Kim Moir [:kmoir] ET]

In bug 829211 - Use mozpool and mozharness for the Android pandas, shutdown.stamp was inadvertently removed.  This was rectified in bug in bug 888826. Callek mentioned that it should actually be created before mozpool is invoked so this bug is to track this.

Comment 1

[Kim Moir [:kmoir] ET]

right now it's invoked right before the tests start

Comment 2

[Kim Moir [:kmoir] ET]

Attachment: bug900970.patch

Tested in staging for talos and non-talos tests. Also, I removed the extra dirs dir = self.query_abs_dirs() here


if 'jittest' in suite:
-                    dirs = self.query_abs_dirs()
                     self._download_unzip(self.query_jsshell_url(), dirs['abs_test_bin_dir'])

because it's called above and not needed

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 809250 [details] [diff] [review]
bug900970.patch

Review of attachment 809250 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/android_panda.py
@@ +171,5 @@
> +            self.info("*** Touching the shutdown file **")
> +            open(shutdown_file, 'w').close()
> +        except Exception, e:
> +            self.warning("We failed to create the shutdown file: str(%s)" % str(e)) 
> +    

nit: whitespace EOL

::: scripts/android_panda_talos.py
@@ +124,5 @@
> +           self.info("*** Touching the shutdown file **")
> +           open(shutdown_file, 'w').close()
> +        except Exception, e:
> +           self.warning("We failed to create the shutdown file: str(%s)" % str(e))
> +            

nit: whitespace EOL

Comment 4

[Kim Moir [:kmoir] ET]

Comment on attachment 809250 [details] [diff] [review]
bug900970.patch

fixed whitespace

Comment 5

[Kim Moir [:kmoir] ET]

merged to production

Comment 6

[Kim Moir [:kmoir] ET]

verified on cedar