Closed Bug 900970 Opened 8 years ago Closed 8 years ago

shutdown.stamp should be created before mozpool is invoked

Categories

(Infrastructure & Operations Graveyard :: CIDuty, task)

x86
macOS
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kmoir, Assigned: kmoir)

References

Details

Attachments

(1 file)

In bug 829211 - Use mozpool and mozharness for the Android pandas, shutdown.stamp was inadvertently removed.  This was rectified in bug in bug 888826. Callek mentioned that it should actually be created before mozpool is invoked so this bug is to track this.
Assignee: nobody → kmoir
Product: mozilla.org → Release Engineering
right now it's invoked right before the tests start
Attached patch bug900970.patchSplinter Review
Tested in staging for talos and non-talos tests. Also, I removed the extra dirs dir = self.query_abs_dirs() here


if 'jittest' in suite:
-                    dirs = self.query_abs_dirs()
                     self._download_unzip(self.query_jsshell_url(), dirs['abs_test_bin_dir'])

because it's called above and not needed
Attachment #809250 - Flags: review?(bugspam.Callek)
Comment on attachment 809250 [details] [diff] [review]
bug900970.patch

Review of attachment 809250 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/android_panda.py
@@ +171,5 @@
> +            self.info("*** Touching the shutdown file **")
> +            open(shutdown_file, 'w').close()
> +        except Exception, e:
> +            self.warning("We failed to create the shutdown file: str(%s)" % str(e)) 
> +    

nit: whitespace EOL

::: scripts/android_panda_talos.py
@@ +124,5 @@
> +           self.info("*** Touching the shutdown file **")
> +           open(shutdown_file, 'w').close()
> +        except Exception, e:
> +           self.warning("We failed to create the shutdown file: str(%s)" % str(e))
> +            

nit: whitespace EOL
Attachment #809250 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 809250 [details] [diff] [review]
bug900970.patch

fixed whitespace
Attachment #809250 - Flags: checked-in+
merged to production
verified on cedar
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.