900979 - Change JS_DeleteProperty APIs to use a boolean out param rather than a value

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Jon Coppeard (:jonco)]

As suggested in a previous bug, this is pretty pointless as all callers just unpack it into a bool again anyway.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: bool-out-params

Changes inside the JS engine

Comment 3

[Jon Coppeard (:jonco)]

Attachment: bool-out-params-browser

Changes in the rest of the browser

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 785025 [details] [diff] [review]
bool-out-params-browser

> +  return !!(ok && deleted);

Just ok && deleted, please.

r=me if we're sure we want JSBool and not bool here.

Comment 5

[Tom S [:evilpie]]

We want bool. See Bug 898914.

Comment 6

[Jeff Walden [:Waldo]]

Comment on attachment 785024 [details] [diff] [review]
bool-out-params

Review of attachment 785024 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine modulo any bool-ification that should happen.  That should be trivial enough I don't need to see it.

Comment 7

[Jon Coppeard (:jonco)]

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #6)

Ok, I'll convert the API to use bool*, but leave the conversion of the internal implementation to bug 898914.

Comment 8

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/29385afa711f

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/29385afa711f

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

\o/