Twitter share button needs updated autofill text

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacob, Assigned: mjschranz)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Right now the tweet button under the "share" tab in Popcorn Maker autofills the following text:

Check out the #PopcornMaker page I just made:  https://jake.makes.org/popcorn/1ac6 via @popcornjs

There are two things wrong with this

1) We don't follow the hashtag #popcornmaker and it's a bit long
2) @popcornjs is not @webmaker

so let's change it to the following:

Check out the #Webmaker page I just made:  https://jake.makes.org/popcorn/1ac6 via @Webmaker
+111111.  Been meaning to file that for a while!  Matt, how'd you like to take this one?
Assignee: nobody → schranz.m
(Assignee)

Comment 2

5 years ago
Created attachment 785187 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/151

Cade for a code review.

Cassie, can you let me know if the text there is good?
Attachment #785187 - Flags: review?(cade)
Attachment #785187 - Flags: feedback?(cassie)
Comment on attachment 785187 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/151

R+

Will this conflict with the localization work being done?
Attachment #785187 - Flags: review?(cade) → review+
(In reply to Matthew Schranz [:mjschranz] from comment #2)
> Created attachment 785187 [details] [review]
> https://github.com/mozilla/popcorn.webmaker.org/pull/151
> 
> Cade for a code review.
> 
> Cassie, can you let me know if the text there is good?

Sounds good to me!! Only thing I noticed in Jacob's copy was that there were two spaces in front of the link instead of one.
Attachment #785187 - Flags: feedback?(cassie)
(Assignee)

Comment 5

5 years ago
(In reply to Chris DeCairos (:cade) from comment #3)
> Comment on attachment 785187 [details] [review]
> https://github.com/mozilla/popcorn.webmaker.org/pull/151
> 
> R+
> 
> Will this conflict with the localization work being done?

Yes, this is probably somewhere we will want to do some localization as well.

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.