Closed
Bug 901111
Opened 11 years ago
Closed 11 years ago
When editing an event with invalid data, despite the warning, the data is still saved.
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(blocking-b2g:koi+)
VERIFIED
FIXED
| blocking-b2g | koi+ |
People
(Reporter: gghosh, Assigned: gghosh)
Details
Attachments
(1 file, 2 obsolete files)
|
46 bytes,
patch
|
jlal
:
review+
|
Details | Diff | Splinter Review |
The data is not actually saved but cached and shows the user the invalid data. But if you refresh, the data is correct.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #785364 -
Flags: review?(jlal)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #785364 -
Attachment is obsolete: true
Attachment #785364 -
Flags: review?(jlal)
Attachment #785574 -
Flags: review?(jlal)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 785574 [details] [diff] [review]
Event only commits if valid
some minor style needs should be fine after.. Please flag me for review (after rebasing).
Attachment #785574 -
Flags: review?(jlal) → review-
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #785574 -
Attachment is obsolete: true
Attachment #786155 -
Flags: review?(jlal)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 786155 [details] [diff] [review]
Event only commits if valid
I would like to give this a quick manual check but r+ on the code side this looks really nice. I will land this after I give it a quick check.
Attachment #786155 -
Flags: review?(jlal) → review+
|
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Updated•11 years ago
|
blocking-b2g: --- → koi?
|
||
Comment 8•11 years ago
|
||
Verified Fix: User cannot save (or does not appear to save) an edit to an event that has an end date before the start date. Tested Offline, Google, Yahoo, and CalDav Calendars.
Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131103004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/eec4da1b27eb
Gaia: cb981e2f47bc644b4d178d54378c3676c946facf
Platform Version: 26.0
RIL Version: 01.01.00.019.276
Firmware Version: US_20131015
Status: RESOLVED → VERIFIED
|
||
Updated•11 years ago
|
Assignee: nobody → gghosh
You need to log in
before you can comment on or make changes to this bug.
Description
•