When editing an event with invalid data, despite the warning, the data is still saved.

VERIFIED FIXED

Status

Firefox OS
Gaia::Calendar
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: Ganesh Ghosh, Assigned: Ganesh Ghosh)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(blocking-b2g:koi+)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
The data is not actually saved but cached and shows the user the invalid data. But if you refresh, the data is correct.
(Assignee)

Comment 1

5 years ago
Created attachment 785364 [details] [diff] [review]
Event only commits if valid
Attachment #785364 - Flags: review?(jlal)
(Assignee)

Comment 2

5 years ago
Created attachment 785574 [details] [diff] [review]
Event only commits if valid
Attachment #785364 - Attachment is obsolete: true
Attachment #785364 - Flags: review?(jlal)
Attachment #785574 - Flags: review?(jlal)
Comment on attachment 785574 [details] [diff] [review]
Event only commits if valid

some minor style needs should be fine after.. Please flag me for review (after rebasing).
Attachment #785574 - Flags: review?(jlal) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 786155 [details] [diff] [review]
Event only commits if valid
Attachment #785574 - Attachment is obsolete: true
Attachment #786155 - Flags: review?(jlal)
Comment on attachment 786155 [details] [diff] [review]
Event only commits if valid

I would like to give this a quick manual check but r+ on the code side this looks really nice. I will land this after I give it a quick check.
Attachment #786155 - Flags: review?(jlal) → review+
https://github.com/mozilla-b2g/gaia/commit/08dfcb5d5b8ea395ab56043b2700bbdcf0841ac4
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
blocking-b2g: --- → koi?

Comment 7

5 years ago
fixed
blocking-b2g: koi? → koi+
Verified Fix: User cannot save (or does not appear to save) an edit to an event that has an end date before the start date. Tested Offline, Google, Yahoo, and CalDav Calendars.

Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131103004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/eec4da1b27eb
Gaia: cb981e2f47bc644b4d178d54378c3676c946facf
Platform Version: 26.0
RIL Version: 01.01.00.019.276 
Firmware Version: US_20131015
Status: RESOLVED → VERIFIED

Updated

4 years ago
Assignee: nobody → gghosh
You need to log in before you can comment on or make changes to this bug.