901117 - Platform touch fluffing needs the ability to weed out body event listeners

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Wesley Johnston (:wesj)]

I turned on the platform event fluffing for Android today and noticed we don't seem to be doing much fluffing on google.com. Some logging showed that we're finding event listeners on the html element itself (maybe those come from document.addEventListener?)

In Fennec's current code base, we actually ignore the body/html elements unless we're actually looking at fluffed out targets. Not when we're just deciding whether or not its worth it to fluff out the current target.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch v1

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 785281 [details] [diff] [review]
Patch v1

Need to clean this up a bit. Does it seem reasonable tn?

Comment 3

[Timothy Nikkel (:tnikkel)]

Comment on attachment 785281 [details] [diff] [review]
Patch v1

If this is what we are doing on Fennec then this seems reasonable.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: touch3

Made this a bit more general. Running this on try (with this feature turned on for Android):

https://hg.mozilla.org/try/rev/f0b3ece1f3d5

Comment 5

[Timothy Nikkel (:tnikkel)]

Comment on attachment 785815 [details] [diff] [review]
touch3

So now both IsElementClickable stop at the body tag? The first patch just had one. Why the change?

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Patch

Don't know where I lost that, but yes, we only really want this on our initial check.

Comment 7

[Timothy Nikkel (:tnikkel)]

Comment on attachment 785832 [details] [diff] [review]
Patch

I would make stopAt default to nullptr.

Comment 8

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3883090a1fa5

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3883090a1fa5