Closed Bug 901117 Opened 7 years ago Closed 7 years ago

Platform touch fluffing needs the ability to weed out body event listeners

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

Other
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: wesj, Assigned: wesj)

References

Details

Attachments

(1 file, 2 obsolete files)

I turned on the platform event fluffing for Android today and noticed we don't seem to be doing much fluffing on google.com. Some logging showed that we're finding event listeners on the html element itself (maybe those come from document.addEventListener?)

In Fennec's current code base, we actually ignore the body/html elements unless we're actually looking at fluffed out targets. Not when we're just deciding whether or not its worth it to fluff out the current target.
Blocks: 859629
Attached patch Patch v1 (obsolete) — Splinter Review
Comment on attachment 785281 [details] [diff] [review]
Patch v1

Need to clean this up a bit. Does it seem reasonable tn?
Attachment #785281 - Flags: feedback?(tnikkel)
Blocks: 788073
Comment on attachment 785281 [details] [diff] [review]
Patch v1

If this is what we are doing on Fennec then this seems reasonable.
Attachment #785281 - Flags: feedback?(tnikkel) → feedback+
Attached patch touch3 (obsolete) — Splinter Review
Made this a bit more general. Running this on try (with this feature turned on for Android):

https://hg.mozilla.org/try/rev/f0b3ece1f3d5
Attachment #785281 - Attachment is obsolete: true
Attachment #785815 - Flags: review?(tnikkel)
Comment on attachment 785815 [details] [diff] [review]
touch3

So now both IsElementClickable stop at the body tag? The first patch just had one. Why the change?
Attached patch PatchSplinter Review
Don't know where I lost that, but yes, we only really want this on our initial check.
Attachment #785815 - Attachment is obsolete: true
Attachment #785815 - Flags: review?(tnikkel)
Attachment #785832 - Flags: review?(tnikkel)
Comment on attachment 785832 [details] [diff] [review]
Patch

I would make stopAt default to nullptr.
Attachment #785832 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/mozilla-central/rev/3883090a1fa5
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.