javascript strict warnings in widgetglue.js

VERIFIED FIXED

Status

SeaMonkey
MailNews: Message Display
VERIFIED FIXED
17 years ago
12 years ago

People

(Reporter: Henrik Gemal, Assigned: (not reading, please use seth@sspitzer.org instead))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

590 bytes, patch
(not reading, please use seth@sspitzer.org instead)
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

17 years ago
When I pressed "Compact this folder" on a subfolder called Trash under Trash:

Warning: assignment to undeclared variable folderuri
Source File: chrome://messenger/content/widgetglue.js
Line: 221

build 20010708 on win2k
I think this is INVALID now, because here's line 218 to 223:

function NotifyQuitApplication()
{
	var ObserverService =
Components.classes["@mozilla.org/observer-service;1"].getService();
	ObserverService =
ObserverService.QueryInterface(Components.interfaces.nsIObserverService);
	if (ObserverService)
	{
I grepped for 'folderuri' within this file, and it's part of a funtion name, but
not declared outright as it's own variable now.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → INVALID
verified.
Status: RESOLVED → VERIFIED
REOPENING.

There's another strict JS warning in widgetglue.js which I will create a patch 
for.  (Figured reopening was better than filing a new bug.)

Warning: redeclaration of var msgfolder
Source File: chrome://messenger/content/widgetglue.js
Line: 272, Column: 12
Source Code:
        var msgfolder = resource.QueryInterface
(Components.interfaces.nsIMsgFolder);

Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7+) Gecko/20011220

Patch coming up in about ten minutes.
Status: VERIFIED → REOPENED
Resolution: INVALID → ---
Created attachment 62651 [details] [diff] [review]
patch for above strict warning
Comment on attachment 62651 [details] [diff] [review]
patch for above strict warning

r=bzbarsky
Attachment #62651 - Flags: review+
Comment on attachment 62651 [details] [diff] [review]
patch for above strict warning

sr=sspitzer
Attachment #62651 - Flags: superreview+
fixed.
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago16 years ago
Resolution: --- → FIXED
Verified FIXED with build 2002-01-06-08
Status: RESOLVED → VERIFIED
QA Contact: esther → stephend
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.