90112 - javascript strict warnings in widgetglue.js

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Henrik Gemal]

When I pressed "Compact this folder" on a subfolder called Trash under Trash:

Warning: assignment to undeclared variable folderuri
Source File: chrome://messenger/content/widgetglue.js
Line: 221

build 20010708 on win2k

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

I think this is INVALID now, because here's line 218 to 223:

function NotifyQuitApplication()
{
	var ObserverService =
Components.classes["@mozilla.org/observer-service;1"].getService();
	ObserverService =
ObserverService.QueryInterface(Components.interfaces.nsIObserverService);
	if (ObserverService)
	{
I grepped for 'folderuri' within this file, and it's part of a funtion name, but
not declared outright as it's own variable now.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

verified.

Comment 3

[Alex Vincent [:WeirdAl]]

REOPENING.

There's another strict JS warning in widgetglue.js which I will create a patch 
for.  (Figured reopening was better than filing a new bug.)

Warning: redeclaration of var msgfolder
Source File: chrome://messenger/content/widgetglue.js
Line: 272, Column: 12
Source Code:
        var msgfolder = resource.QueryInterface
(Components.interfaces.nsIMsgFolder);

Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7+) Gecko/20011220

Patch coming up in about ten minutes.

Comment 4

[Alex Vincent [:WeirdAl]]

Attachment: patch for above strict warning

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 62651 [details] [diff] [review]
patch for above strict warning

r=bzbarsky

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 62651 [details] [diff] [review]
patch for above strict warning

sr=sspitzer

Comment 7

[(not reading, please use [e-mail] instead)]

fixed.

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED with build 2002-01-06-08