901134 - [Helix] Marketplace icon is not a rounded icon

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Swaroopa Vantipalli [:swaroopa]]

Attachment: Helix_MarketPlaceIcon

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f0e9fcb591c2
Gaia   64f48c2cebddbbfb2bdeb93a88b3c6817f45736a
BuildID 20130802072203
Version 18.0

STR:

1. Go to home screen and observe the shape of the market place app icon

Expected Result:

In all FFOS phones the market place app has a rounded icon.

Actual Result:

The app does not have a rounded icon

Comment 1

[Wayne Chang [:wchang]]

Hi Amy,
Not sure if you can also help with this?

Comment 2

[Amy Lee [:amylee] UX]

Attachment: Icon_Marketplace.png

Hi, 

Attached is the rounded marketplace icon. Let me know if you need anything else.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Swaroopa, on which build did you experience this? Did you ever update the Marketplace or get a system update or was this from a fresh build?

Comment 4

[Swaroopa Vantipalli [:swaroopa]]

the build details are :
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f0e9fcb591c2
Gaia   64f48c2cebddbbfb2bdeb93a88b3c6817f45736a
BuildID 20130802072203
Version 18.0

I did not do any update. This was a fresh build

Comment 5

[Jason Smith [:jsmith]]

This is probably a POVB issue on Helix's side with the marketplace app being preinstalled incorrectly.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

(In reply to Jason Smith [:jsmith] from comment #5)
> This is probably a POVB issue on Helix's side with the marketplace app being
> preinstalled incorrectly.

Can show me what the external-apps/marketplace.firefox.com/ directory looks like in this build? In particular I'm interested in the value of the manifestURL: https://github.com/mozilla-b2g/gaia/blob/master/external-apps/marketplace.firefox.com/metadata.json#L4

Comment 7

[Swaroopa Vantipalli [:swaroopa]]

Here is more update:
When I Flash the build using the command "GAIA_DEV_PIXELS_PER_PX=1.5 make reset-gaia"
I can see the rounded Market place icon.

As the bug 898602 was fixed, I thought we can start flashing using our usual flash script. So when I Flashed using the Flash script, I can see all icons in HD but market place icon is not rounded.

Comment 8

[Jason Smith [:jsmith]]

Note - the testing here needs to be done one of two ways to confirm this is a bug:

1. By flashing a rel eng Helix build
2. By flashing a partner production image directly

Can someone confirm what happens in these two scenarios?

Comment 9

[Jason Smith [:jsmith]]

This is a flash script bug using full flash from a HD build here - https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-b2g18_v1_1_0_hd-helix/latest/.

Not POVB cause this is in our script.

Comment 10

[Wayne Chang [:wchang]]

Hi John, Perhaps you'll have some insight here?

(In reply to Swaroopa Vantipalli [:swaroopa] from comment #7)
> Here is more update:
> When I Flash the build using the command "GAIA_DEV_PIXELS_PER_PX=1.5 make
> reset-gaia"
> I can see the rounded Market place icon.
> 
> As the bug 898602 was fixed, I thought we can start flashing using our usual
> flash script. So when I Flashed using the Flash script, I can see all icons
> in HD but market place icon is not rounded.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I did some digging there: the application.zip exists in Gaia (on both master and hd branch) comes with a square 120.png and a rounded 60.png. On the hd phone, the home screen will attempt to show image larger or equal to 60 * 1.5 = 90px, so that's why square icon gets shown.

Chris, would it be possible for you to update the zip to include *rounded* icons of these sizes: 60.png 90.png 120.png?

Comment 12

[Christopher Van Wiemeersch [:cvan]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/11934

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 799836 [details]
https://github.com/mozilla-b2g/gaia/pull/11934

I am not be able to the zip'd application.zip nor the base64 hash but overall it looks good.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/a0dee10cd04b849991230d377de8f1e924c482bf

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/67d98e2fd683412a63d0f33954f2489a94fede0a

Comment 16

[Al Tsai [:atsai]]

[2013/10/21 Helix Testing]
Gaia:     c829a2042594b6c3a4899ee27979799a0f301534
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID   20131015042201
Version   18.0