Non-cross compile builds' clang++ host compiler doesn't use the __float128 workaround

RESOLVED FIXED in Firefox 25

Status

RESOLVED FIXED
5 years ago
10 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

24 Branch
mozilla26
x86_64
Linux

Firefox Tracking Flags

(firefox25 fixed, firefox26 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Same problem as bug 900775.
(Assignee)

Comment 1

5 years ago
Created attachment 785275 [details] [diff] [review]
Add the clang workaround for __float128 to HOST_CXXFLAGS when not cross-compiling
Attachment #785275 - Flags: review?(ted)
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla

Comment 2

5 years ago
Unless I'm wrong, this bug seems to break builds with Clang, at least on Linux.
Attachment #785275 - Flags: review?(ted) → review+
(Assignee)

Comment 4

5 years ago
Comment on attachment 785275 [details] [diff] [review]
Add the clang workaround for __float128 to HOST_CXXFLAGS when not cross-compiling

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 895915
User impact if declined: Local developer builds may fail with clang on Linux. This also affects dxr builds, but i don't think they run on aurora. This probably affects asan builds too.
Testing completed (on m-c, etc.): Tested locally
Risk to taking this patch (and alternatives if risky): Low
String or IDL/UUID changes made by this patch: None
Attachment #785275 - Flags: approval-mozilla-aurora?

Comment 5

5 years ago
Add to that that the patch works for me (compiles and fixes the issue).
If you have link errors after this patch, try clearing ccache.
https://hg.mozilla.org/mozilla-central/rev/4752e1aea7b1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Attachment #785275 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/67a933f6521f
status-firefox25: --- → fixed
status-firefox26: --- → fixed

Updated

10 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.