901149 - Non-cross compile builds' clang++ host compiler doesn't use the __float128 workaround

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Same problem as bug 900775.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add the clang workaround for __float128 to HOST_CXXFLAGS when not cross-compiling

Comment 2

[Alex Xu]

Unless I'm wrong, this bug seems to break builds with Clang, at least on Linux.

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4752e1aea7b1

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 785275 [details] [diff] [review]
Add the clang workaround for __float128 to HOST_CXXFLAGS when not cross-compiling

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 895915
User impact if declined: Local developer builds may fail with clang on Linux. This also affects dxr builds, but i don't think they run on aurora. This probably affects asan builds too.
Testing completed (on m-c, etc.): Tested locally
Risk to taking this patch (and alternatives if risky): Low
String or IDL/UUID changes made by this patch: None

Comment 5

[Alex Xu]

Add to that that the patch works for me (compiles and fixes the issue).

Comment 6

[Paul Rouget [:paul]]

If you have link errors after this patch, try clearing ccache.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4752e1aea7b1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/67a933f6521f