901151 - Sent mouse event source

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: WIP Patch

The platform uses the source of the mouse event to determine if it should do fluffing (i.e. only fluff mouse events that come from touches). We should set the source. While we're doing it, I thought I'd try to get us sending normal mouse events as well.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Trying to send mouse events through the platform is getting there, but will need some work and is lower priority. This part is needed for bug 788073 and is easy.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Ran into an error in the last guy. Fixed

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 785992 [details] [diff] [review]
Patch

Review of attachment 785992 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/browser.js
@@ +4251,5 @@
>  
>              // the target should already have been fluffed by the platform touch event code, but
>              // will be fluffed out again by the platform mouse event code as well
> +            let window = element.ownerDocument.defaultView;
> +            let cwu = window.top.QueryInterface(Ci.nsIInterfaceRequestor).getInterface(Ci.nsIDOMWindowUtils);

Not your fault, but it might be a good idea to rename "window" to "win" or something else so we don't have a local variable hiding a built-in global variable. That seems like a potential footgun.

@@ +4515,2 @@
>      try {
> +      cwu.sendMouseEventToWindow(aName, aX, aY, 0, 1, 0, true, 1.0, aSource);

Maybe it makes sense to just inline this function? I don't know if it's worth catching exceptions on each of these events individually, we could just do it as a block around all three of them. If one throws I double the other two won't anyway.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/6e7a45127e07

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Something in this push caused robocop-2 perma-orange. Backed out.
https://hg.mozilla.org/integration/fx-team/rev/1fb5d14e8348

https://tbpl.mozilla.org/php/getParsedLog.php?id=26227297&tree=Fx-Team

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.