901177 - merge JSON minidump_stackwalk into socorro repo

Status: RESOLVED FIXED

(Socorro :: Infra, task)

Description

[Robert Helmer [:rhelmer]]

Ted's stackwalk server (which includes JSON output support) currently lives in http://hg.mozilla.org/users/tmielczarek_mozilla.com/minidump-stackwalk/

We should put this in a more permanent location - Ted does not wish to land it in breakpad repo, it move to a more permanent home (such as in the Socorro repo).

Only wrinkle I can think of right now is that we have a separate Jenkins breakpad job, and this needs access to breakpad header and .a files, so we'd have to checkout the repo as part of that job, or move the breakpad build into the main socorro job (it's slow and doesn't change that often, which is why it's build+packaged separately)

Comment 1

[Lonnen :lonnen]

Subtree or submodule?

Comment 2

[(not currently active) Ted Mielczarek]

(stackwalk server was an old experiment, FWIW, I've just been reusing the same repo for all my MDSW experiments.)

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Chris Lonnen :lonnen from comment #1)
> Subtree or submodule?

I think subtree in Socorro repo would be fine, it means we'll need to check out the Socorro repo in the breakpad project too (which isn't so bad really).

We should be able to use hg-git mercurial plugin to convert it over.

Comment 4

[(not currently active) Ted Mielczarek]

I'm not super concerned about preserving history here, FWIW. A lot of the history of that repo is not relevant (and it has a lot of other irrelevant branches).

Comment 5

[Lonnen :lonnen]

PR for merging the code in is here: https://github.com/mozilla/socorro/pull/1389

I don't think I understand the build process changes that need to accompany this, though.

Comment 6

[Robert Helmer [:rhelmer]]

I'll go ahead and make the build system changes in this bug too.

Comment 7

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro/pull/1576

Note that there's a separate "breakpad" job on Jenkins, we'll need to switch it over to use this instead of checking out breakpad directly. It's already pulling the build script from Socorro so we might as well check the whole repo out over there too.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/ba51b1bd8d4598e9d9d347558502b73bc122b262
fixes bug 901177 - build system changes for json stackwalker

https://github.com/mozilla/socorro/commit/766a245363a90ef8e95a043a3aad5e6faf125674
Merge pull request #1576 from rhelmer/bug901177-build-json-stackwalker

fixes bug 901177 - build system changes for json stackwalker

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/96e28fb99740a711c373b3e6aeee7f9a8a39eb31
fixes bug 901177 - no need to rename breakpad to stackwalk anymore

https://github.com/mozilla/socorro/commit/2ab7a046e7bc2a6b719c82f1d6891ee5414704bb
Merge pull request #1577 from rhelmer/bug901177-fix-breakpad-build

fixes bug 901177 - no need to rename breakpad to stackwalk anymore

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/3c1449e32b93f82ff8eebb01b308a6e6181fceb0
Revert "fixes bug 901177 - build system changes for json stackwalker"

This reverts commit ba51b1bd8d4598e9d9d347558502b73bc122b262.

https://github.com/mozilla/socorro/commit/e81493fe2ed4c7807cc621645a46c4d3b40d4ed4
Revert "fixes bug 901177 - no need to rename breakpad to stackwalk anymore"

This reverts commit 96e28fb99740a711c373b3e6aeee7f9a8a39eb31.

Comment 11

[Lonnen :lonnen]

reverted, but will re-land for 64

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c4a02b0f5defd920ac4eb0140861d6c7bcafddfc
fixes bug 901177 - no need to rename breakpad to stackwalk anymore

This reverts commit e81493fe2ed4c7807cc621645a46c4d3b40d4ed4.

https://github.com/mozilla/socorro/commit/5f2181ff09a645f56097fa6890e6411435cda625
fixes bug 901177 - build system changes for json stackwalker

This reverts commit 3c1449e32b93f82ff8eebb01b308a6e6181fceb0.

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/498b7b289725c7930109c6a6fb2412d8672fad52
fixes bug 901177 - build system changes for json stackwalker