901187 - Send printf_stderr output to OutputDebugString

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

+++ This bug was initially created as a clone of Bug #762519 +++

Similar to the bug I'm cloning, I would like printf_stderr to go to the Visual Studio console output to make debugging on Metro easier.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 785331 [details] [diff] [review]
Patch

Not sure who should review this, feel free to bounce it as needed.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Sorry, haven't gotten the right patch generation flags on this windows machine.

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 785333 [details] [diff] [review]
Patch

Looks ok but I can't r+ something in xpcom glue.

Comment 4

[Benjamin Smedberg]

Comment on attachment 785333 [details] [diff] [review]
Patch

Is there a particular reason why you early-return here, instead of printing to both stderr and OutputDebugStringA ?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Not particularly, no. I can let it fall through. I can also refactor the code to reduce duplication but that might result in the stderr version getting truncated at 2047 bytes as well, so maybe we don't want that.

Comment 6

[Benjamin Smedberg]

Yeah, I'm not particularly worried about the truncation, but I'd like it to always print to stderr, because I personally at least often pipe output to a file even while I'm in a debugger session.

Comment 7

[Benjamin Smedberg]

Comment on attachment 785333 [details] [diff] [review]
Patch

r=me with the return removed

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Landed with the return statement removed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4a05768e8c3

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e4a05768e8c3