901239 - Uplift Add-on SDK to Firefox

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://github.com/mozilla/addon-sdk/compare/08ac4ddab9...3cc6527a5d

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2d80e7cf6e09

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

And backed out for breaking Jetpack tests: https://hg.mozilla.org/integration/mozilla-inbound/rev/0dbbfff22016

Failures looked like this: https://tbpl.mozilla.org/php/getParsedLog.php?id=26123576&tree=Mozilla-Inbound

TEST-UNEXPECTED-FAIL | tests/test-content-script.test Object Listener 2 | origin matches testHost - true == false
TEST-INFO | Traceback (most recent call last):
  File "resource://gre/modules/commonjs/sdk/timers.js", line 40, in notify
    callback.apply(null, args);
  File "resource://gre/modules/commonjs/sdk/content/worker.js", line 102, in null
    self._emit.apply(self, JSON.parse(args));
  File "resource://gre/modules/commonjs/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://gre/modules/commonjs/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://gre/modules/commonjs/sdk/content/worker.js", line 234, in portEmit
    self._addonWorker._onContentScriptEvent.apply(self._addonWorker, arguments);
  File "resource://gre/modules/commonjs/sdk/content/worker.js", line 592, in _onContentScriptEvent
    this._port._emit.apply(this._port, arguments);
  File "resource://gre/modules/commonjs/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://gre/modules/commonjs/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://extensions.modules.bb7e8d9a-afc4-4751-a5a2-f59ffbf9faf9-at-jetpack.commonjs.path.tests/test-content-script.js", line 87, in createWorker/<
    assert.ok(data.assertion, data.msg);
  File "resource://gre/modules/commonjs/sdk/test/assert.js", line 103, in ok
    operator: "=="
  File "resource://gre/modules/commonjs/sdk/test/assert.js", line 89, in fail
    this._log.fail(message);
  File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 84, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://gre/modules/commonjs/sdk/test/harness.js", line 525, in testMessage
    this.trace();




TEST-START | tests/test-content-script.test localStorage
TEST-PASS | tests/test-content-script.test localStorage | correct URL loaded
JavaScript strict warning: resource://gre/modules/XPIProvider.jsm -> jar:file:///var/folders/Hs/HsDn6a9SG8idoIya6p9mtE+++TI/-Tmp-/tmpouvdj9.mozrunner/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/private-browsing/utils.js, line 28: reference to undefined property Cc['@mozilla.org/privatebrowsing;1']
JavaScript strict warning: resource://gre/modules/XPIProvider.jsm -> jar:file:///var/folders/Hs/HsDn6a9SG8idoIya6p9mtE+++TI/-Tmp-/tmpouvdj9.mozrunner/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/method/core.js, line 102: reference to undefined property value[("!" + name)]
console.error: addon-sdk: 
  Message: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIDOMWindow.localStorage]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: javascript:new function () {
        assert = function assert(v, msg) {
          self.port.emit("assert", {assertion:v, msg:msg});
        }
        done = function done() {
          self.port.emit("done");
        }
      };
new function ContentScriptScope() {
      // Check localStorage:
      assert(window.localStorage, "has access to localStorage");
      window.localStorage.name = 1;
      assert(window.localStorage.name == 1, "localStorage appears to work");

      self.port.on("step2", function () {
        window.localStorage.clear();
        assert(window.localStorage.name == undefined, "localStorage really, really works");
        done();
      });
      self.port.emit("step1");
    } :: ContentScriptScope :: line 11"  data: no]
TEST-UNEXPECTED-FAIL | tests/test-content-script.test localStorage | Test output exceeded timeout (60s).
Traceback (most recent call last):
  File "jetpack/bin/cfx", line 33, in <module>
    cuddlefish.run()
  File "/Users/cltbld/talos-slave/test/build/jetpack/python-lib/cuddlefish/__init__.py", line 608, in run
    test_all_packages(env_root, defaults=options.__dict__)
  File "/Users/cltbld/talos-slave/test/build/jetpack/python-lib/cuddlefish/__init__.py", line 490, in test_all_packages
    env_root=env_root)
  File "/Users/cltbld/talos-slave/test/build/jetpack/python-lib/cuddlefish/__init__.py", line 937, in run
    pkgdir=options.pkgdir)
  File "/Users/cltbld/talos-slave/test/build/jetpack/python-lib/cuddlefish/runner.py", line 742, in run_app
    OUTPUT_TIMEOUT, test_name, parseable)
Exception: Test output exceeded timeout (60s).

Comment 3

[Dave Townsend [:mossop]]

Now landing https://github.com/mozilla/addon-sdk/compare/08ac4dd...a2b5119
https://hg.mozilla.org/integration/fx-team/rev/9c17e6d4739d

Comment 4

[Dave Townsend [:mossop]]

And backed out again due to exactly the same test failures ... whut?

https://hg.mozilla.org/integration/fx-team/rev/98eea46a58d3

Comment 5

[Dave Townsend [:mossop]]

Ok, backed out the offending patch.

https://github.com/mozilla/addon-sdk/compare/08ac4dd...f435558
https://hg.mozilla.org/integration/fx-team/rev/56a9aa45de9b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/56a9aa45de9b