901339 - Panning & zooming does still not work well on Browser after bug 866232

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Julien Wajsberg [:julienw]]

I tried applying patches in bug 899810 and bug 900742 but zooming/panning on http://ratp.fr is still wrong:

* sometimes it just doesn't work
* sometimes the gesture to panning does zooming instead
* when zooming, the focal point is also still not right

Comment 1

[Kartikaya Gupta (email:[e-mail])]

(In reply to Julien Wajsberg [:julienw] from comment #0)
> * sometimes the gesture to panning does zooming instead

This one should be fixed by bug 898443. I will look into the other two parts of this.

Comment 2

[Chris Kreinbring [:CKreinbring]]

I have repro steps for this bug:

1. Launch the browser and navigate to a site, espacially one with lots of content (eg yahoo.com).
2. Scroll down and up the page.

The page will eventually freeze and become unresponsive, forcing the user to close the browser completely and reload it.  The length of time varies, but it's never more than a minute.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

This fixes a screwup on my part in bug 866232, part 8 (https://hg.mozilla.org/mozilla-central/rev/9a4478e65fd6). The original code had mFrameMetrics.mScrollOffset multiplied by "paintedScale" which was actually the CSSToLayerScale of the painted frame metrics rather than the APZC's internal frame metrics. In my refactoring I accidentally changed it to use the APZC's internal frame metrics instead. This fixes that and also factors out the multiplication.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

:bbondy, can you also verify if the attached patch fixes the focal point when zooming for you?

Comment 5

[Brian R. Bondy [:bbondy]]

Comment on attachment 786955 [details] [diff] [review]
Patch

Review of attachment 786955 [details] [diff] [review]:
-----------------------------------------------------------------

Yes this works a million times better now :)

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8427bf2c4652

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8427bf2c4652