Closed Bug 901340 Opened 6 years ago Closed 6 years ago

Clicking buttons does not work on Browser after bug 866232

Categories

(Core :: Graphics: Layers, defect)

25 Branch
ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla26
blocking-b2g koi+
Tracking Status
firefox26 --- fixed

People

(Reporter: julienw, Assigned: kats)

References

Details

(Keywords: regression, smoketest)

I tried applying patches in bug 899810 and bug 900742 but clicking buttons on http://everlong.org/mozilla/notifications/ still doesn't work.
Blocks: 866232
No longer depends on: 866232
Version: 22 Branch → 25 Branch
My patches on bug 890280 fix this for me locally. I'll leave this open for now because those patches are still WIPs and might change before they land. I'll re-verify this is fixed with the final versions of the patches when it lands.
Assignee: nobody → bugmail.mozilla
blocking-b2g: --- → koi+
Keywords: smoketest
Keywords: regression
I landed the patches from bug 890280 that should fix this, although I left that bug as open for now. The patches are currently on b2g-inbound, and should be on central today or tomorrow. Please let me know if you still see this issue with those patches.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2)
> I landed the patches from bug 890280 that should fix this, although I left
> that bug as open for now. The patches are currently on b2g-inbound, and
> should be on central today or tomorrow. Please let me know if you still see
> this issue with those patches.

I'll put qawanted for a retest post landing of those patches on central.
Keywords: qawanted
Verified fixed on today's 8/15 build - my test pages using input=submit tags are working again.
Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: qawanted
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla26
Can we get unit and/or JS-integration tests for this?
you mean, on the gaia side ?
(In reply to Stephen Donner [:stephend] from comment #5)
> Can we get unit and/or JS-integration tests for this?

Note - we do have https://github.com/mozilla/gaia-ui-tests/issues/1248 on the gaia ui tests side that aims to provide test coverage for this.
(In reply to Julien Wajsberg [:julienw] from comment #6)
> you mean, on the gaia side ?

Yes.
(In reply to Jason Smith [:jsmith] from comment #7)
> (In reply to Stephen Donner [:stephend] from comment #5)
> > Can we get unit and/or JS-integration tests for this?
> 
> Note - we do have https://github.com/mozilla/gaia-ui-tests/issues/1248 on
> the gaia ui tests side that aims to provide test coverage for this.

Yes, but now that we have an actual integration-tests story, I'd love to see if we can shift the code coverage closer to the app.
looping browser guys to this discussion.

Probably should do it in another bug though.
You need to log in before you can comment on or make changes to this bug.