901385 - test_mutationobservers.html failing on b2g and Android mochitest because of the use of showModalDialog

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Martijn Wargers (zombie)]

This test file contains about 149 tests, which 9 of them are making use of showModalDialog.
B2g and Android currently don't support showModalDialog (Android bug is bug 753555) and since this test doesn't really concentrate on testing this feature specifically, would it be ok to put a try..catch around that particular test code?

Something like this:
  try {
    window.showModalDialog("mutationobserver_dialog.html");
    ok(didHandleCallback, "Should have called the callback while showing modal dialog!");
  } catch(e) {
    todo(false, "showModalDialog not implemented on this platform");
  }

This would at least allow the rest of the tests to run on Android and b2g.

Comment 1

[Olli Pettay [:smaug]]

try-catch sounds ok.

Comment 2

[Martijn Wargers (zombie)]

Attachment: 901385.diff

Comment 3

[Martijn Wargers (zombie)]

Pused to try: https://tbpl.mozilla.org/?tree=Try&rev=4bfdf81c6180

Comment 4

[Martijn Wargers (zombie)]

Attachment: 901385_final.diff

Try server all green, this patch is check-in ready.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5cc8c8e09d5a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5cc8c8e09d5a