Closed Bug 901385 Opened 6 years ago Closed 6 years ago

test_mutationobservers.html failing on b2g and Android mochitest because of the use of showModalDialog

Categories

(Testing :: Mochitest, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

References

()

Details

Attachments

(1 file, 1 obsolete file)

This test file contains about 149 tests, which 9 of them are making use of showModalDialog.
B2g and Android currently don't support showModalDialog (Android bug is bug 753555) and since this test doesn't really concentrate on testing this feature specifically, would it be ok to put a try..catch around that particular test code?

Something like this:
  try {
    window.showModalDialog("mutationobserver_dialog.html");
    ok(didHandleCallback, "Should have called the callback while showing modal dialog!");
  } catch(e) {
    todo(false, "showModalDialog not implemented on this platform");
  }

This would at least allow the rest of the tests to run on Android and b2g.
try-catch sounds ok.
Attached patch 901385.diff (obsolete) — Splinter Review
Attachment #785560 - Flags: review?(bugs)
Attachment #785560 - Flags: review?(bugs) → review+
Try server all green, this patch is check-in ready.
Attachment #785560 - Attachment is obsolete: true
Assignee: nobody → martijn.martijn
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5cc8c8e09d5a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.