Closed
Bug 901418
Opened 11 years ago
Closed 11 years ago
Bookmark toolbar items are no longer visible in the nav-bar after customization
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: MattN, Assigned: Gijs)
References
Details
(Keywords: regression, Whiteboard: [Australis:P4][Australis:M9])
Attachments
(1 file)
40.30 KB,
image/png
|
Details |
STR: 1) Start with a fresh profile and go into customization mode 2) Move the bookmark toolbar items from the bookmark toolbar to the left of the back button (first item in the nav-bar) 3) Leave customization mode Expected: Bookmarks appear the left of the back button Actual: Bookmark toolbar items don't appear anywhere. This just happened after I updated to today's UX Nightly so I suspect the cause is bug 895938. I can repro in a new profile.
Comment 1•11 years ago
|
||
was that working before? I'm not sure why that position would be special, the item is definitely there.
Reporter | ||
Comment 2•11 years ago
|
||
Yes, I've had my toolbar like this since I started using the UX branch.
Comment 3•11 years ago
|
||
Honestly, I don't think I'll be able to look into this anytime "soon" (that means likely a couple weeks), though any part that required deeper Places knowledge should have been handled already, so I hope someone may just handle it as a UI bug. Otherwise I will look into it, when possible.
Comment 4•11 years ago
|
||
Please back out bug 895938, then.
Comment 5•11 years ago
|
||
(In reply to Jesse Ruderman from comment #4) > Please back out bug 895938, then. I don't see why, UX is an experimental project branch and this bug is a very edge case (the back button is the first one in the toolbar for a very good reason), we can live with it for a while, provided no one suggests a fix in the meanwhile (should not be that hard).
Comment 6•11 years ago
|
||
And moreover backing out things from a so quick moving project branch is more damaging than doing good, I had to unbitrot the same patches over and over in just a week.
Comment 7•11 years ago
|
||
(In reply to Marco Bonardo [:mak] (Away Aug 14-18) from comment #5) > (In reply to Jesse Ruderman from comment #4) > > Please back out bug 895938, then. > > I don't see why, UX is an experimental project branch It's only bad luck that it couldn't be merged to mozilla-central by now. You shouldn't assume it has a considerably lower quality bar.
Comment 8•11 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #7) > It's only bad luck that it couldn't be merged to mozilla-central by now. You > shouldn't assume it has a considerably lower quality bar. I don't this this lowers the quality bar considerebly, it's still an edge case, I'd give the same answer in Nightly. It's surely something that should be fixed before merging to Aurora, that's it, imo. Btw, I can take this now.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Updated•11 years ago
|
Whiteboard: [Australis:P?][Australis:M?]
Updated•11 years ago
|
Whiteboard: [Australis:P?][Australis:M?] → [Australis:P4][Australis:M?]
Comment 9•11 years ago
|
||
This bug isn't as edge-casey as comment 0 makes it sound. It also happens with the bookmarks placed after the address bar.
Comment 10•11 years ago
|
||
the patch in bug 909729 should fix this
Assignee: mak77 → gijskruitbosch+bugs
Assignee | ||
Comment 11•11 years ago
|
||
https://hg.mozilla.org/projects/ux/rev/8d12999288a9 (from bug 909729)
OS: Mac OS X → All
Whiteboard: [Australis:P4][Australis:M?] → [Australis:P4][Australis:M9][fixed-in-ux]
Comment 12•11 years ago
|
||
Assignee | ||
Comment 13•11 years ago
|
||
(In reply to Jesse Ruderman from comment #12) > Created attachment 808268 [details] > Not quite what I wanted... Please file a separate bug with steps to reproduce, including how many bookmarks are in your bookmarks toolbar and whether or not it goes out of the overflow list if you make the window wider.
Comment 14•11 years ago
|
||
Other than that problem, which went away when I opened a new browser window, things seem to work. I'll file a new bug if I can reproduce in a new profile.
Updated•11 years ago
|
Target Milestone: --- → Future
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 15•11 years ago
|
||
By convention we have been keeping bugs in ASSIGNED state until the patches are merged to mozilla-central.
Status: REOPENED → ASSIGNED
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4][Australis:M9][fixed-in-ux] → [Australis:P4][Australis:M9]
Assignee | ||
Comment 16•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8d12999288a9
Assignee | ||
Updated•11 years ago
|
Target Milestone: Future → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•