Closed
Bug 901447
Opened 11 years ago
Closed 11 years ago
Missing Title Error should help the user understand that they need a title
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: laura, Assigned: thecount)
Details
Attachments
(1 file)
STR: go to thimble.webmaker.org delete the text between the <title> and </<title> hit publish You will get this error: Sorry, an error occurred while trying to publish. {"message":"Validation failed","name":"ValidationError","errors":{"title":{"message":"Validator \"required\" failed for path title","name":"ValidatorError","path":"title","type":"required"}},"__NR_CAUGHT":true} We need to change that to let the user know that they do not have a title on their page. The above error confuses users, and because they can't publish, they get frustrated :)
There should be code that injects the current date-time when a user publishes without a title. This suggests that codepath is not being hit, which is actually a bug. Thanks for the report!
Assignee: nobody → scott
Assignee | ||
Comment 2•11 years ago
|
||
Pomax, can you take this? I don't see myself getting to it anytime soon.
Assignee | ||
Comment 3•11 years ago
|
||
An empty title should use the project id. However, at some point the makeapi made title required and validate it so empty strings are not valid titles. This patch now passes in the project id as the title to the makeapi too.
Attachment #806097 -
Flags: review?(pomax)
Comment on attachment 806097 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/217 validation~~~~ *shakes fist in air*
Attachment #806097 -
Flags: review?(pomax) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Staged: https://github.com/mozilla/thimble.webmaker.org/commit/23ec4a6c975dd2e7a72ebb07a4305032d7ed9121 Needs verification.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•