901500 - Add missing assets to master for email app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Eric Pang [:epang] UX]

Some graphics in the email app are missing on master but are on 1.1hd.  This bug will add the missing assets.

Comment 1

[Eric Pang [:epang] UX]

Attachment: Pull Request

Hi Sam,

I've added a missing image and updated another image (just a swap) in the email app.  Can you review?

Thanks!

Comment 2

[Sam Joch [:samjoch]]

Same here Eric: Can you update the commit message. (should be: Bug 901500 - Add missing assets to master for email app)

Comment 3

[Eric Pang [:epang] UX]

(In reply to Sam Joch [:samjoch] from comment #2)
> Same here Eric: Can you update the commit message. (should be: Bug 901500 -
> Add missing assets to master for email app)

updated, sorry I wasn't aware of this before.  Thanks!

Comment 4

[Sam Joch [:samjoch]]

Comment on attachment 785807 [details] [diff] [review]
Pull Request

Landed in master: https://github.com/mozilla-b2g/gaia/commit/a282e7fc6cf39e4c891642575dc441ded878ed1d

Comment 5

[Eric Pang [:epang] UX]

(In reply to Sam Joch [:samjoch] from comment #4)
> Comment on attachment 785807 [details] [diff] [review]
> Pull Request
> 
> Landed in master:
> https://github.com/mozilla-b2g/gaia/commit/
> a282e7fc6cf39e4c891642575dc441ded878ed1d

Thanks Sam!  Naoki, this is ready for verification :) thx!

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

epang, samjoch, I'm still not seeing the watermark when there's no email in the folder.

## Environment :
"gecko" revision="a8daa428ccbc"
"gecko" revision="f7df54d21e1b4fed66083d80b701c3692e1cffd4"
"gaia" revision="58bb05efc83407428099a182244a1759ab84cd0b"
Build ID: 2013-08-15-04-02-04
MC/master build
Unagi

Comment 7

[Eric Pang [:epang] UX]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #6)
> epang, samjoch, I'm still not seeing the watermark when there's no email in
> the folder.
> 
> ## Environment :
> "gecko" revision="a8daa428ccbc"
> "gecko" revision="f7df54d21e1b4fed66083d80b701c3692e1cffd4"
> "gaia" revision="58bb05efc83407428099a182244a1759ab84cd0b"
> Build ID: 2013-08-15-04-02-04
> MC/master build
> Unagi

Hi Naoki, sorry for the delayed response on this.  This is correct a while back we removed the watermark since we didn't think it was needed :). Thanks for pointed it out!

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Hi Eric,
There's some inconsistancies:
1.1 HD : 
https://github.com/mozilla-b2g/gaia/tree/v1.1.0hd/apps/email/style/images
shows [e-mail]
And the images that you posted are already there.
Master:
https://github.com/mozilla-b2g/gaia/tree/master/apps/email/style/images
shows your images and is missing [e-mail]

In both cases : pattern.png is missing a @1.5x version.

Is this correct?  I'm a bit confused by the situation.

Comment 9

[Eric Pang [:epang] UX]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #8)
> Hi Eric,
> There's some inconsistancies:
> 1.1 HD : 
> https://github.com/mozilla-b2g/gaia/tree/v1.1.0hd/apps/email/style/images
> shows [e-mail]
> And the images that you posted are already there.
> Master:
> https://github.com/mozilla-b2g/gaia/tree/master/apps/email/style/images
> shows your images and is missing [e-mail]
> 
> In both cases : pattern.png is missing a @1.5x version.
> 
> Is this correct?  I'm a bit confused by the situation.

Hi Naoki,

for the mail watermark images.  I think they are no longer needed and can be removed (so we don't display them anymore).  I believe we left all patterns at 1x and didn't re-size for 1.5x, that's why you aren't seeing a 1.5x version.  Hope that clarifies things abit :).

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Ok then it's by design.  Thanks!

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified as per design