Closed Bug 901519 Opened 8 years ago Closed 8 years ago

[app manager] data store for connections

Categories

(DevTools Graveyard :: WebIDE, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: paul, Assigned: paul)

References

Details

Attachments

(1 file)

No description provided.
Blocks: 898487
Attached patch Patch v1Splinter Review
Attachment #789541 - Flags: review?(poirot.alex)
Blocks: 901521
No longer blocks: 898487
Blocks: 898487
No longer blocks: 901521
Depends on: 901521
Depends on: 898485
Blocks: 901520
Comment on attachment 789541 [details] [diff] [review]
Patch v1

Review of attachment 789541 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/app-manager/connection-store.js
@@ +13,5 @@
> +    return _knownConnectionStores.get(connection);
> +  }
> +  _knownConnectionStores.set(connection, this);
> +
> +  ObservableObject.call(this, {status:null,host:null,port:null});

Be carefull to land bug 901517 before this one.

@@ +19,5 @@
> +  this._destroy = this._destroy.bind(this);
> +  this._feedStore = this._feedStore.bind(this);
> +
> +  this._connection = connection;
> +  this._connection.once("destroyed", this._destroy);

nit: "destroyed" -> ConnectionsManager.DESTROYED

::: browser/devtools/app-manager/test/test_connection_store.html
@@ +93,5 @@
> +          SimpleTest.finish();
> +        }
> +
> +        connection.host = null; // force pipe
> +        connection.port = null;

What about having ConnectionsManager.createPipeConnection() to make that non-magic and explicit?
Otherwise, we at least need to document that "no host = pipe" in connection-manager!
Attachment #789541 - Flags: review?(poirot.alex) → review+
Depends on: 901517
> What about having ConnectionsManager.createPipeConnection() to make that
> non-magic and explicit?
> Otherwise, we at least need to document that "no host = pipe" in
> connection-manager!

I'll do that in a follow up.
https://hg.mozilla.org/mozilla-central/rev/1ed0042c0e79
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.