901519 - [app manager] data store for connections

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Comment 1

[Paul Rouget [:paul]]

Attachment: Patch v1

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 789541 [details] [diff] [review]
Patch v1

Review of attachment 789541 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/app-manager/connection-store.js
@@ +13,5 @@
> +    return _knownConnectionStores.get(connection);
> +  }
> +  _knownConnectionStores.set(connection, this);
> +
> +  ObservableObject.call(this, {status:null,host:null,port:null});

Be carefull to land bug 901517 before this one.

@@ +19,5 @@
> +  this._destroy = this._destroy.bind(this);
> +  this._feedStore = this._feedStore.bind(this);
> +
> +  this._connection = connection;
> +  this._connection.once("destroyed", this._destroy);

nit: "destroyed" -> ConnectionsManager.DESTROYED

::: browser/devtools/app-manager/test/test_connection_store.html
@@ +93,5 @@
> +          SimpleTest.finish();
> +        }
> +
> +        connection.host = null; // force pipe
> +        connection.port = null;

What about having ConnectionsManager.createPipeConnection() to make that non-magic and explicit?
Otherwise, we at least need to document that "no host = pipe" in connection-manager!

Comment 3

[Paul Rouget [:paul]]

> What about having ConnectionsManager.createPipeConnection() to make that
> non-magic and explicit?
> Otherwise, we at least need to document that "no host = pipe" in
> connection-manager!

I'll do that in a follow up.

Comment 4

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/1ed0042c0e79

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1ed0042c0e79