Go to the make details page of any make, i.e. https://ollie.makes.org/popcorn/105p and hit the share button, which brings up the Twitter button. Hit the twitter button and you get this autofill text: Tweet this awesome popcorn project: https://ollie.makes.org/popcorn/105p via @#webmaker There's an error in the text - instead it should say "via @webmaker" not "via @#webmaker" The hashtag # symbol needs to be removed. Also an editorial suggestion. "Tweet this awesome popcorn project" is a little confusing, why not simply "Check out this awesome popcorn project" Or, since we're trying to use the term "make" instead of "project" "Check out this awesome Popcorn make" - though that sounds a bit awkward :P
Dale, can you look at this please?
Assignee: nobody → dale
Status: NEW → ASSIGNED
Created attachment 803991 [details] Code Review https://github.com/mozilla/webmaker.org/pull/366/files
Attachment #803991 - Flags: review?(kate)
Comment on attachment 803991 [details] Code Review Good, but please localize
Attachment #803991 - Flags: review?(kate) → review-
Attachment #804015 - Flags: review?(kate)
Attachment #804015 - Flags: review?(kate) → review+
Commits pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/5ecb9a4a458b409101b294cbc306240fd7a84d87 [bug 901596] Fix Twitter share text https://github.com/mozilla/webmaker.org/commit/337f84b7f1f8272af1a2d61c44ac88df41c7f874 Merge pull request #366 from daleee/901596-twitter-error [bug 901596] Fix Twitter share text
Checked staging, issue resolved.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.