901596 - Error in tweet button auto-fill text on details page

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Jacob [:Jacob]]

Go to the make details page of any make, i.e. https://ollie.makes.org/popcorn/105p and hit the share button, which brings up the Twitter button.

Hit the twitter button and you get this autofill text:

Tweet this awesome popcorn project:  https://ollie.makes.org/popcorn/105p via @#webmaker

There's an error in the text - instead it should say "via @webmaker" not "via @#webmaker"

The hashtag # symbol needs to be removed.

Also an editorial suggestion. "Tweet this awesome popcorn project" is a little confusing, why not simply "Check out this awesome popcorn project"

Or, since we're trying to use the term "make" instead of "project"

"Check out this awesome Popcorn make" - though that sounds a bit awkward :P

Comment 1

[David Humphrey (:humph)]

Dale, can you look at this please?

Comment 2

[Dale Karp (:daleee)]

Attachment: Code Review

https://github.com/mozilla/webmaker.org/pull/366/files

Comment 3

[inactivate account for kate]

Comment on attachment 803991 [details]
Code Review

Good, but please localize

Comment 4

[Dale Karp (:daleee)]

Attachment: CR2

https://github.com/mozilla/webmaker.org/pull/366/files

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/5ecb9a4a458b409101b294cbc306240fd7a84d87
[bug 901596] Fix Twitter share text

https://github.com/mozilla/webmaker.org/commit/337f84b7f1f8272af1a2d61c44ac88df41c7f874
Merge pull request #366 from daleee/901596-twitter-error

[bug 901596] Fix Twitter share text

Comment 6

[Dale Karp (:daleee)]

Checked staging, issue resolved.