Error in tweet button auto-fill text on details page

RESOLVED FIXED

Status

Webmaker
webmaker.org
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacob, Assigned: daleee)

Tracking

Details

Attachments

(2 attachments)

54 bytes, text/plain
inactivate account for kate
: review-
Details
CR2
54 bytes, text/plain
inactivate account for kate
: review+
Details
(Reporter)

Description

5 years ago
Go to the make details page of any make, i.e. https://ollie.makes.org/popcorn/105p and hit the share button, which brings up the Twitter button.

Hit the twitter button and you get this autofill text:

Tweet this awesome popcorn project:  https://ollie.makes.org/popcorn/105p via @#webmaker

There's an error in the text - instead it should say "via @webmaker" not "via @#webmaker"

The hashtag # symbol needs to be removed.

Also an editorial suggestion. "Tweet this awesome popcorn project" is a little confusing, why not simply "Check out this awesome popcorn project"

Or, since we're trying to use the term "make" instead of "project"

"Check out this awesome Popcorn make" - though that sounds a bit awkward :P
Dale, can you look at this please?
Assignee: nobody → dale
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 803991 [details]
Code Review

https://github.com/mozilla/webmaker.org/pull/366/files
Attachment #803991 - Flags: review?(kate)
Comment on attachment 803991 [details]
Code Review

Good, but please localize
Attachment #803991 - Flags: review?(kate) → review-
Attachment #804015 - Flags: review?(kate) → review+
(Assignee)

Comment 6

5 years ago
Checked staging, issue resolved.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.