Closed
Bug 901612
Opened 11 years ago
Closed 11 years ago
delete unused headers from DOMError.h
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: froydnj, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
|
1.02 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•11 years ago
|
||
The header doesn't use BindingUtils.h or nsCycleCollectionParticipant.h. It ought to be able to forward-declare ErrorResult and remove ErrorResult.h, but that runs into forward-declaration-after-actual-declaration errors, which is kind of unfortunate.
Attachment #785867 -
Flags: review?(bzbarsky)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 785867 [details] [diff] [review] delete unused headers from DOMError.h Scratch this, new patch coming with ErrorResult forward-declared in the correct namespace.
Attachment #785867 -
Flags: review?(bzbarsky)
|
|
Reporter | |
Comment 3•11 years ago
|
||
Here's one with unused headers deleted and ErrorResult simply forward-declared.
Attachment #785867 -
Attachment is obsolete: true
Attachment #785882 -
Flags: review?(bzbarsky)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 785882 [details] [diff] [review] delete unused headers from DOMError.h r=me
Attachment #785882 -
Flags: review?(bzbarsky) → review+
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9b0b4a26e7c7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
Assignee | |
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•