901644 - Allow mach build paths to be specified relative to $srcdir

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Dave Camp (:dcamp)]

I'd like to be able to build what I'm working on from anywhere.  Maybe mach build /browser could be relative to srcdir?

Comment 1

[Gregory Szorc [:gps]]

That's a fair request.

Code for resolving a mach build argument/target into a make target lives at https://hg.mozilla.org/mozilla-central/file/default/python/mozbuild/mozbuild/util.py#l156.

Comment 2

[(not currently active) Ted Mielczarek]

I feel like we discussed this but I can't find a record of it. Having "mach build /browser" build $topsrcdir/browser seems totally sane.

Comment 3

[Dave Camp (:dcamp)]

Attachment: mach-absolute.diff

As simple as this?

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 787135 [details] [diff] [review]
mach-absolute.diff

Review of attachment 787135 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/integration/mozilla-inbound/rev/a82f3a08ff3a

(with nits I fixed for you to make up for the review lag)

::: python/mozbuild/mozbuild/util.py
@@ +178,5 @@
>  
>      target = target.replace(os.sep, '/')
>  
> +    if target[0] == '/':
> +        target = target[1:]

target = target.lstrip('/')

Comment 5

[Phil Ringnalda (:philor)]

Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/a727146d85e2 since it turns out to have a test, which that failed.

Comment 6

[Gregory Szorc [:gps]]

Tests can be executed by running:

mach python-test python/mozbuild/mozbuild/test/

Comment 7

[Dave Camp (:dcamp)]

Attachment: v2

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 795151 [details] [diff] [review]
v2

Review of attachment 795151 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/test/test_util.py
@@ +123,5 @@
>  
> +    def test_root_path(self):
> +        self.assertResolve('/test-dir', ('test-dir', None))
> +        self.assertResolve('/test-dir/with', ('test-dir/with', None))
> +        self.assertResolve('/test-dir/with', ('test-dir/with', None))

Why the duplicate test?

Comment 9

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/05fe61b1a309

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/05fe61b1a309